bk commit into 5.1 tree (jonas:1.1924)

[jonas]

Below is the list of changes that have just been committed into a local
5.1 repository of jonas. When jonas does a push these changes will
be propagated to the main repository and, within 24 hours after the
push, to the public repository.
For information on how to access the public repository
see http://dev.mysql.com/doc/mysql/en/installing-source-tree.html

ChangeSet
  1.1924 05/10/12 10:31:34 jonas@stripped +3 -0
  ndb - bug with index build of unique index with 32 attributes
    since NDB$FRAGMENT is automatically added, there was a over run in the struct

  storage/ndb/src/kernel/blocks/dbdict/Dbdict.hpp
    1.21 05/10/12 10:31:28 jonas@stripped +3 -2
    Fix unique index with 32 attributes

  storage/ndb/src/kernel/blocks/dbdict/Dbdict.cpp
    1.59 05/10/12 10:31:28 jonas@stripped +3 -1
    Fix unique index with 32 attributes

  storage/ndb/include/kernel/AttributeList.hpp
    1.5 05/10/12 10:31:28 jonas@stripped +6 -2
    Fix unique index with 32 attributes

# This is a BitKeeper patch.  What follows are the unified diffs for the
# set of deltas contained in the patch.  The rest of the patch, the part
# that BitKeeper cares about, is below these diffs.
# User:	jonas
# Host:	perch.ndb.mysql.com
# Root:	/home/jonas/src/mysql-5.1

--- 1.4/storage/ndb/include/kernel/AttributeList.hpp	2005-06-13 15:16:11 +02:00
+++ 1.5/storage/ndb/include/kernel/AttributeList.hpp	2005-10-12 10:31:28 +02:00
@@ -26,9 +26,13 @@
 
 typedef Bitmask<MAXNROFATTRIBUTESINWORDS> AttributeMask;
 
-struct AttributeList {
+template <Uint32 SZ>
+struct Id_array
+{
   Uint32 sz;
-  Uint32 id[MAX_ATTRIBUTES_IN_INDEX];
+  Uint32 id[SZ];
 };
+
+typedef Id_array<MAX_ATTRIBUTES_IN_INDEX> AttributeList;
 
 #endif

--- 1.58/storage/ndb/src/kernel/blocks/dbdict/Dbdict.cpp	2005-10-07 01:06:18 +02:00
+++ 1.59/storage/ndb/src/kernel/blocks/dbdict/Dbdict.cpp	2005-10-12 10:31:28 +02:00
@@ -12128,7 +12128,8 @@
 */
 
 void
-Dbdict::getTableKeyList(TableRecordPtr tablePtr, AttributeList& list)
+Dbdict::getTableKeyList(TableRecordPtr tablePtr, 
+			Id_array<MAX_ATTRIBUTES_IN_INDEX+1>& list)
 {
   jam();
   list.sz = 0;
@@ -12139,6 +12140,7 @@
       list.id[list.sz++] = aRec->attributeId;
     tAttr = aRec->nextAttrInTable;
   }
+  ndbrequire(list.sz <= MAX_ATTRIBUTES_IN_INDEX + 1);
 }
 
 // XXX should store the primary attribute id

--- 1.20/storage/ndb/src/kernel/blocks/dbdict/Dbdict.hpp	2005-09-16 06:52:33 +02:00
+++ 1.21/storage/ndb/src/kernel/blocks/dbdict/Dbdict.hpp	2005-10-12 10:31:28 +02:00
@@ -1263,7 +1263,7 @@
     // original request plus buffer for attribute lists
     BuildIndxReq m_request;
     AttributeList m_attrList;
-    AttributeList m_tableKeyList;
+    Id_array<MAX_ATTRIBUTES_IN_INDEX+1> m_tableKeyList;
     // coordinator DICT
     Uint32 m_coordinatorRef;
     bool m_isMaster;
@@ -2048,7 +2048,8 @@
   void alterTrigger_sendSlaveReq(Signal* signal, OpAlterTriggerPtr opPtr);
   void alterTrigger_sendReply(Signal* signal, OpAlterTriggerPtr opPtr, bool);
   // support
-  void getTableKeyList(TableRecordPtr tablePtr, AttributeList& list);
+  void getTableKeyList(TableRecordPtr, 
+		       Id_array<MAX_ATTRIBUTES_IN_INDEX+1>& list);
   void getIndexAttr(TableRecordPtr indexPtr, Uint32 itAttr, Uint32* id);
   void getIndexAttrList(TableRecordPtr indexPtr, AttributeList& list);
   void getIndexAttrMask(TableRecordPtr indexPtr, AttributeMask& mask);