From: Date: October 12 2005 12:23am
Subject: bk commit into 4.1 tree (jimw:1.2490) BUG#6413
List-Archive: http://lists.mysql.com/internals/30939
X-Bug: 6413
Message-Id: <20051011222338.96CD0A8390@rama.trainedmonkey.com>

Below is the list of changes that have just been committed into a local
4.1 repository of jimw. When jimw does a push these changes will
be propagated to the main repository and, within 24 hours after the
push, to the public repository.
For information on how to access the public repository
see http://dev.mysql.com/doc/mysql/en/installing-source-tree.html

ChangeSet
  1.2490 05/10/11 15:23:34 jimw@stripped +1 -0
  Fix read past allocated buffer when parsing charsets file. (Bug #6413)

  strings/xml.c
    1.5 05/10/11 15:23:32 jimw@stripped +1 -1
    Don't look for comment past end of buffer.

# This is a BitKeeper patch.  What follows are the unified diffs for the
# set of deltas contained in the patch.  The rest of the patch, the part
# that BitKeeper cares about, is below these diffs.
# User:	jimw
# Host:	rama.(none)
# Root:	/home/jimw/my/mysql-4.1-6413

--- 1.4/strings/xml.c	2004-10-19 15:28:36 -07:00
+++ 1.5/strings/xml.c	2005-10-11 15:23:32 -07:00
@@ -81,7 +81,7 @@
   a->beg=p->cur;
   a->end=p->cur;
   
-  if (!bcmp(p->cur,"<!--",4))
+  if ((p->end - p->cur > 3) && !bcmp(p->cur,"<!--",4))
   {
     for( ; (p->cur < p->end) && bcmp(p->cur, "-->", 3); p->cur++)
     {}