From: Date: September 23 2005 11:39pm Subject: bk commit into 4.1 tree (sergefp:1.2460) BUG#12232 List-Archive: http://lists.mysql.com/internals/30289 X-Bug: 12232 Message-Id: <20050923213956.A068137AFC@newbox.mylan> Below is the list of changes that have just been committed into a local 4.1 repository of psergey. When psergey does a push these changes will be propagated to the main repository and, within 24 hours after the push, to the public repository. For information on how to access the public repository see http://dev.mysql.com/doc/mysql/en/installing-source-tree.html ChangeSet 1.2460 05/09/24 01:39:50 sergefp@stripped +5 -0 BUG#12232: Addressing docs team feedback: s/inequal/unequal/ sql/mysqld.cc 1.601 05/09/24 01:39:47 sergefp@stripped +4 -4 BUG#12232: Addressing docs team feedback: s/inequal/unequal/ sql/ha_myisam.cc 1.161 05/09/24 01:39:47 sergefp@stripped +1 -1 BUG#12232: Addressing docs team feedback: s/inequal/unequal/ mysql-test/r/myisam.result 1.53 05/09/24 01:39:46 sergefp@stripped +2 -2 BUG#12232: Addressing docs team feedback: s/inequal/unequal/ myisam/myisamchk.c 1.128 05/09/24 01:39:46 sergefp@stripped +3 -3 BUG#12232: Addressing docs team feedback: s/inequal/unequal/ myisam/mi_check.c 1.151 05/09/24 01:39:46 sergefp@stripped +1 -1 BUG#12232: Addressing docs team feedback: s/inequal/unequal/ # This is a BitKeeper patch. What follows are the unified diffs for the # set of deltas contained in the patch. The rest of the patch, the part # that BitKeeper cares about, is below these diffs. # User: sergefp # Host: newbox.mylan # Root: /home/psergey/mysql-4.1-csc6030-r3 --- 1.150/myisam/mi_check.c 2005-09-21 02:18:26 +04:00 +++ 1.151/myisam/mi_check.c 2005-09-24 01:39:46 +04:00 @@ -3994,7 +3994,7 @@ ... The 'unique' array is collected in one sequential scan through the entire index. This is done in two places: in chk_index() and in sort_key_write(). - Statistics collection may consider NULLs as either equal or inequal (see + Statistics collection may consider NULLs as either equal or unequal (see SEARCH_NULL_ARE_NOT_EQUAL, MI_STATS_METHOD_*). Output is an array: --- 1.127/myisam/myisamchk.c 2005-09-21 19:30:25 +04:00 +++ 1.128/myisam/myisamchk.c 2005-09-24 01:39:46 +04:00 @@ -67,7 +67,7 @@ "no zeros", "blob", "constant", "table-lockup", "always zero","varchar","unique-hash","?","?"}; -static const char *myisam_stats_method_str="nulls_inequal"; +static const char *myisam_stats_method_str="nulls_unequal"; static void get_options(int *argc,char * * *argv); static void print_version(void); @@ -339,7 +339,7 @@ REQUIRED_ARG, 0, 0, 0, 0, 0, 0}, {"stats_method", OPT_STATS_METHOD, "Specifies how index statistics collection code should threat NULLs. " - "Possible values of name are \"nulls_inequal\" (default behavior for 4.1/5.0), and \"nulls_equal\" (emulate 4.0 behavior).", + "Possible values of name are \"nulls_unequal\" (default behavior for 4.1/5.0), and \"nulls_equal\" (emulate 4.0 behavior).", (gptr*) &myisam_stats_method_str, (gptr*) &myisam_stats_method_str, 0, GET_STR, REQUIRED_ARG, 0, 0, 0, 0, 0, 0}, { 0, 0, 0, 0, 0, 0, GET_NO_ARG, NO_ARG, 0, 0, 0, 0, 0, 0} @@ -471,7 +471,7 @@ #include -const char *myisam_stats_method_names[] = {"nulls_inequal", "nulls_equal", +const char *myisam_stats_method_names[] = {"nulls_unequal", "nulls_equal", NullS}; TYPELIB myisam_stats_method_typelib= { array_elements(myisam_stats_method_names) - 1, "", --- 1.160/sql/ha_myisam.cc 2005-09-21 02:18:26 +04:00 +++ 1.161/sql/ha_myisam.cc 2005-09-24 01:39:47 +04:00 @@ -39,7 +39,7 @@ TYPELIB myisam_recover_typelib= {array_elements(myisam_recover_names)-1,"", myisam_recover_names, NULL}; -const char *myisam_stats_method_names[] = {"nulls_inequal", "nulls_equal", +const char *myisam_stats_method_names[] = {"nulls_unequal", "nulls_equal", NullS}; TYPELIB myisam_stats_method_typelib= { array_elements(myisam_stats_method_names) - 1, "", --- 1.600/sql/mysqld.cc 2005-09-23 23:14:09 +04:00 +++ 1.601/sql/mysqld.cc 2005-09-24 01:39:47 +04:00 @@ -369,7 +369,7 @@ char *my_bind_addr_str; const char **errmesg; /* Error messages */ const char *myisam_recover_options_str="OFF"; -const char *myisam_stats_method_str="nulls_inequal"; +const char *myisam_stats_method_str="nulls_unequal"; const char *sql_mode_str="OFF"; /* name of reference on left espression in rewritten IN subquery */ const char *in_left_expr_name= ""; @@ -5212,7 +5212,7 @@ GET_ULONG, REQUIRED_ARG, 8192*1024, 4, ~0L, 0, 1, 0}, {"myisam_stats_method", OPT_MYISAM_STATS_METHOD, "Specifies how MyISAM index statistics collection code should threat NULLs. " - "Possible values of name are \"nulls_inequal\" (default behavior for 4.1/5.0), and \"nulls_equal\" (emulate 4.0 behavior).", + "Possible values of name are \"nulls_unequal\" (default behavior for 4.1/5.0), and \"nulls_equal\" (emulate 4.0 behavior).", (gptr*) &myisam_stats_method_str, (gptr*) &myisam_stats_method_str, 0, GET_STR, REQUIRED_ARG, 0, 0, 0, 0, 0, 0}, {"net_buffer_length", OPT_NET_BUFFER_LENGTH, @@ -5767,7 +5767,7 @@ query_id= thread_id= 1L; strmov(server_version, MYSQL_SERVER_VERSION); myisam_recover_options_str= sql_mode_str= "OFF"; - myisam_stats_method_str= "nulls_inequal"; + myisam_stats_method_str= "nulls_unequal"; my_bind_addr = htonl(INADDR_ANY); threads.empty(); thread_cache.empty(); @@ -5818,7 +5818,7 @@ global_system_variables.old_passwords= 0; /* - Default behavior for 4.1 and 5.0 is to treat NULL values as inequal + Default behavior for 4.1 and 5.0 is to treat NULL values as unequal when collecting index statistics for MyISAM tables. */ global_system_variables.myisam_stats_method= MI_STATS_METHOD_NULLS_NOT_EQUAL; --- 1.52/mysql-test/r/myisam.result 2005-09-21 02:18:26 +04:00 +++ 1.53/mysql-test/r/myisam.result 2005-09-24 01:39:46 +04:00 @@ -611,7 +611,7 @@ drop table t1, t2; show variables like 'myisam_stats_method'; Variable_name Value -myisam_stats_method nulls_inequal +myisam_stats_method nulls_unequal create table t1 (a int, key(a)); insert into t1 values (0),(1),(2),(3),(4); insert into t1 select NULL from t1; @@ -652,7 +652,7 @@ set myisam_stats_method=DEFAULT; show variables like 'myisam_stats_method'; Variable_name Value -myisam_stats_method nulls_inequal +myisam_stats_method nulls_unequal insert into t1 values (11); delete from t1 where a=11; analyze table t1;