From: Date: September 21 2005 1:58am
Subject: bk commit into 4.1 tree (jimw:1.2447) BUG#13064
List-Archive: http://lists.mysql.com/internals/30127
X-Bug: 13064
Message-Id: <20050920235802.9F656A8433@rama.trainedmonkey.com>

Below is the list of changes that have just been committed into a local
4.1 repository of jimw. When jimw does a push these changes will
be propagated to the main repository and, within 24 hours after the
push, to the public repository.
For information on how to access the public repository
see http://dev.mysql.com/doc/mysql/en/installing-source-tree.html

ChangeSet
  1.2447 05/09/20 16:57:58 jimw@stripped +1 -0
  Fix handling of password field at the old size (16 characters) but in
  the UTF-8 character set. (Bug #13064)

  sql/sql_acl.cc
    1.169 05/09/20 16:57:54 jimw@stripped +6 -3
    Take character set of passworld field into account when figuring out
    what format it is in (3.23/4.0 or 4.1).

# This is a BitKeeper patch.  What follows are the unified diffs for the
# set of deltas contained in the patch.  The rest of the patch, the part
# that BitKeeper cares about, is below these diffs.
# User:	jimw
# Host:	rama.(none)
# Root:	/home/jimw/my/mysql-4.1-13064

--- 1.168/sql/sql_acl.cc	2005-09-01 05:57:48 -07:00
+++ 1.169/sql/sql_acl.cc	2005-09-20 16:57:54 -07:00
@@ -193,6 +193,7 @@
   my_bool return_val= 1;
   bool check_no_resolve= specialflag & SPECIAL_NO_RESOLVE;
   char tmp_name[NAME_LEN+1];
+  int password_length;
   DBUG_ENTER("acl_load");
 
   priv_version++; /* Privileges updated */
@@ -250,7 +251,9 @@
 
   init_read_record(&read_record_info,thd,table=tables[1].table,NULL,1,0);
   VOID(my_init_dynamic_array(&acl_users,sizeof(ACL_USER),50,100));
-  if (table->field[2]->field_length < SCRAMBLED_PASSWORD_CHAR_LENGTH_323)
+  password_length= table->field[2]->field_length /
+    table->field[2]->charset()->mbmaxlen;
+  if (password_length < SCRAMBLED_PASSWORD_CHAR_LENGTH_323)
   {
     sql_print_error("Fatal error: mysql.user table is damaged or in "
                     "unsupported 3.20 format.");
@@ -258,10 +261,10 @@
   }
 
   DBUG_PRINT("info",("user table fields: %d, password length: %d",
-		     table->fields, table->field[2]->field_length));
+		     table->fields, password_length));
   
   pthread_mutex_lock(&LOCK_global_system_variables);
-  if (table->field[2]->field_length < SCRAMBLED_PASSWORD_CHAR_LENGTH)
+  if (password_length < SCRAMBLED_PASSWORD_CHAR_LENGTH)
   {
     if (opt_secure_auth)
     {