From: Date: September 13 2005 11:35pm
Subject: bk commit into 5.0 tree (elliot:1.1950) BUG#12870
List-Archive: http://lists.mysql.com/internals/29772
X-Bug: 12870
Message-Id: <20050913213529.F0F531A43E3@desperate.raraavisresearch.com>

Below is the list of changes that have just been committed into a local
5.0 repository of emurphy. When emurphy does a push these changes will
be propagated to the main repository and, within 24 hours after the
push, to the public repository.
For information on how to access the public repository
see http://dev.mysql.com/doc/mysql/en/installing-source-tree.html

ChangeSet
  1.1950 05/09/13 17:35:23 elliot@stripped +1 -0
  BUG#12870 (CREATE PROCEDURE followed by ROLLBACK is not replicated)
  Fixed by making CREATE/DROP PROCEDURE cause implicit commit.

  sql/sql_parse.cc
    1.486 05/09/13 17:35:17 elliot@stripped +6 -0
    CREATE/DROP PROCEDURE/SPFUNCTION now causes implicit commit.

# This is a BitKeeper patch.  What follows are the unified diffs for the
# set of deltas contained in the patch.  The rest of the patch, the part
# that BitKeeper cares about, is below these diffs.
# User:	elliot
# Host:	desperate.(none)
# Root:	/home/emurphy/src/work/mysql-5.0-bug-12870

--- 1.485/sql/sql_parse.cc	2005-09-13 06:51:21 -04:00
+++ 1.486/sql/sql_parse.cc	2005-09-13 17:35:17 -04:00
@@ -4017,6 +4017,9 @@
       goto error;
     }
 
+    if (end_active_trans(thd)) 
+      goto error;
+
     if (!lex->sphead->m_db.str || !lex->sphead->m_db.str[0])
     {
       lex->sphead->m_db.length= strlen(thd->db);
@@ -4330,6 +4333,9 @@
 	if (check_routine_access(thd, ALTER_PROC_ACL, db, name,
                                  lex->sql_command == SQLCOM_DROP_PROCEDURE, 0))
           goto error;
+
+  if (end_active_trans(thd)) 
+    goto error;
 #ifndef NO_EMBEDDED_ACCESS_CHECKS
 	if (sp_automatic_privileges && !opt_noacl &&
 	    sp_revoke_privileges(thd, db, name,