bk commit into 4.1 tree (bar:1.2400) BUG#9948

[bar]

Below is the list of changes that have just been committed into a local
4.1 repository of bar. When bar does a push these changes will
be propagated to the main repository and, within 24 hours after the
push, to the public repository.
For information on how to access the public repository
see http://dev.mysql.com/doc/mysql/en/installing-source-tree.html

ChangeSet
  1.2400 05/09/05 20:00:11 bar@stripped +3 -0
  mysqld.cc, mysql_priv.h, sql_parse.cc:
    bug#9948
    changed client-charset behavior in 4.1.x libmysql, which issue BC prob
    after review fixes

  sql/sql_parse.cc
    1.463 05/09/05 19:58:55 bar@stripped +2 -2

  sql/mysqld.cc
    1.592 05/09/05 19:58:42 bar@stripped +6 -6
    bug#9948
    changed client-charset behavior in 4.1.x libmysql, which issue BC prob
    after review fixes

  sql/mysql_priv.h
    1.365 05/09/05 19:58:10 bar@stripped +1 -0
    bug#9948
    changed client-charset behavior in 4.1.x libmysql, which issue BC prob
    after review fixes

# This is a BitKeeper patch.  What follows are the unified diffs for the
# set of deltas contained in the patch.  The rest of the patch, the part
# that BitKeeper cares about, is below these diffs.
# User:	bar
# Host:	bar.intranet.mysql.r18.ru
# Root:	/usr/home/bar/mysql-4.1.b9948

--- 1.364/sql/mysql_priv.h	2005-08-19 08:40:10 +05:00
+++ 1.365/sql/mysql_priv.h	2005-09-05 19:58:10 +05:00
@@ -931,6 +931,7 @@
 extern bool using_update_log, opt_large_files, server_id_supplied;
 extern bool opt_log, opt_update_log, opt_bin_log, opt_slow_log, opt_error_log;
 extern bool opt_disable_networking, opt_skip_show_db;
+extern bool opt_character_set_client_handshake;
 extern bool volatile abort_loop, shutdown_in_progress, grant_option;
 extern uint volatile thread_count, thread_running, global_read_lock;
 extern my_bool opt_sql_bin_update, opt_safe_user_create, opt_no_mix_types;

--- 1.591/sql/mysqld.cc	2005-08-31 12:59:34 +05:00
+++ 1.592/sql/mysqld.cc	2005-09-05 19:58:42 +05:00
@@ -271,7 +271,7 @@
 bool opt_log, opt_update_log, opt_bin_log, opt_slow_log;
 bool opt_error_log= IF_WIN(1,0);
 bool opt_disable_networking=0, opt_skip_show_db=0;
-bool opt_skip_character_set_client_handshake= 0;
+bool opt_character_set_client_handshake= 1;
 bool lower_case_table_names_used= 0;
 bool server_id_supplied = 0;
 bool opt_endinfo,using_udf_functions, locked_in_memory;
@@ -4297,6 +4297,11 @@
    0, 0, 0, GET_STR, REQUIRED_ARG, 0, 0, 0, 0, 0, 0},
   {"bootstrap", OPT_BOOTSTRAP, "Used by mysql installation scripts.", 0, 0, 0,
    GET_NO_ARG, NO_ARG, 0, 0, 0, 0, 0, 0},
+  {"character-set-client-handshake", OPT_CHARACTER_SET_CLIENT_HANDSHAKE,
+   "Don't use client side character set value sent during handshake.",
+   (gptr*) &opt_character_set_client_handshake,
+   (gptr*) &opt_character_set_client_handshake,
+    0, GET_BOOL, NO_ARG, 1, 0, 0, 0, 0, 0},
   {"character-set-server", 'C', "Set the default character set.",
    (gptr*) &default_character_set_name, (gptr*) &default_character_set_name,
    0, GET_STR, REQUIRED_ARG, 0, 0, 0, 0, 0, 0 },
@@ -4755,11 +4760,6 @@
    "Show user and password in SHOW SLAVE HOSTS on this master",
    (gptr*) &opt_show_slave_auth_info, (gptr*) &opt_show_slave_auth_info, 0,
    GET_BOOL, NO_ARG, 0, 0, 0, 0, 0, 0},
-  {"skip-character-set-client-handshake", OPT_CHARACTER_SET_CLIENT_HANDSHAKE,
-   "Don't use client side character set value sent during handshake.",
-   (gptr*) &opt_skip_character_set_client_handshake,
-   (gptr*) &opt_skip_character_set_client_handshake,
-    0, GET_BOOL, NO_ARG, 0, 0, 0, 0, 0, 0},
   {"skip-grant-tables", OPT_SKIP_GRANT,
    "Start without grant tables. This gives all users FULL ACCESS to all tables!",
    (gptr*) &opt_noacl, (gptr*) &opt_noacl, 0, GET_BOOL, NO_ARG, 0, 0, 0, 0, 0,

--- 1.462/sql/sql_parse.cc	2005-08-31 13:00:08 +05:00
+++ 1.463/sql/sql_parse.cc	2005-09-05 19:58:55 +05:00
@@ -811,12 +811,12 @@
     DBUG_PRINT("info", ("client_character_set: %d", (uint) net->read_pos[8]));
     /*
       Use server character set and collation if
-      - opt_skip_character_set_client_handshake is set
+      - opt_character_set_client_handshake is not set
       - client has not specified a character set
       - client character set is the same as the servers
       - client character set doesn't exists in server
     */
-    if (opt_skip_character_set_client_handshake ||
+    if (!opt_character_set_client_handshake ||
         !(thd->variables.character_set_client=
 	  get_charset((uint) net->read_pos[8], MYF(0))) ||
 	!my_strcasecmp(&my_charset_latin1,