bk commit into 5.0 tree (evgen:1.1919) BUG#12489

[eugene]

Below is the list of changes that have just been committed into a local
5.0 repository of evgen. When evgen does a push these changes will
be propagated to the main repository and, within 24 hours after the
push, to the public repository.
For information on how to access the public repository
see http://dev.mysql.com/doc/mysql/en/installing-source-tree.html

ChangeSet
  1.1919 05/08/31 00:54:41 evgen@stripped +3 -0
  Fix bug #12489 wrongly printed strcmp() function results in creation of broken
  view.
  
  For Item_func_strcmp print() was not defined and for this class was called
  print_op of it's parent class. Because of this strcmp() was printed wrongly
  and this results int creation of broken view.
  
  Added function Item_func_strcmp::print() which correctly prints strcmp()
  function.

  mysql-test/t/view.test
    1.102 05/08/31 00:41:00 evgen@stripped +9 -0
    Test case for bug #12489 wrongly printed strcmp() function results in creation of broken view.

  mysql-test/r/view.result
    1.109 05/08/31 00:40:30 evgen@stripped +6 -0
    Test case for bug #12489 wrongly printed strcmp() function results in creation of broken view.

  sql/item_cmpfunc.h
    1.108 05/08/31 00:39:41 evgen@stripped +1 -0
    Fix bug #12489 wrongly printed strcmp() function results in creation of broken view.

# This is a BitKeeper patch.  What follows are the unified diffs for the
# set of deltas contained in the patch.  The rest of the patch, the part
# that BitKeeper cares about, is below these diffs.
# User:	evgen
# Host:	moonbone.local
# Root:	/work/12489-bug-5.0-mysql

--- 1.107/sql/item_cmpfunc.h	2005-08-18 13:07:10 +04:00
+++ 1.108/sql/item_cmpfunc.h	2005-08-31 00:39:41 +04:00
@@ -427,6 +427,7 @@
   longlong val_int();
   optimize_type select_optimize() const { return OPTIMIZE_NONE; }
   const char *func_name() const { return "strcmp"; }
+  void print(String *str) { Item_func::print(str); }
 };
 
 

--- 1.108/mysql-test/r/view.result	2005-08-25 18:47:14 +04:00
+++ 1.109/mysql-test/r/view.result	2005-08-31 00:40:30 +04:00
@@ -2135,3 +2135,9 @@
 ERROR HY000: View 'test.v1' references invalid table(s) or column(s) or function(s)
 DROP TABLE t1;
 DROP VIEW v1;
+create table t1 (f1 char);
+create view v1 as select strcmp(f1,'a') from t1;
+select * from v1;
+strcmp(f1,'a')
+drop view v1;
+drop table t1;

--- 1.101/mysql-test/t/view.test	2005-08-25 18:47:14 +04:00
+++ 1.102/mysql-test/t/view.test	2005-08-31 00:41:00 +04:00
@@ -1995,3 +1995,12 @@
 DESCRIBE v1;
 DROP TABLE t1;
 DROP VIEW v1;
+
+# 
+# Bug #12489 wrongly printed strcmp() function results in creation of broken
+#            view
+create table t1 (f1 char);
+create view v1 as select strcmp(f1,'a') from t1;
+select * from v1;
+drop view v1;
+drop table t1;