From: Date: August 5 2005 1:34pm
Subject: bk commit into 5.0 tree (andrey:1.1945) BUG#11733
List-Archive: http://lists.mysql.com/internals/27916
X-Bug: 11733
Message-Id: <20050805113457.37B3970572@www.hristov.com>

Below is the list of changes that have just been committed into a local
5.0 repository of andrey. When andrey does a push these changes will
be propagated to the main repository and, within 24 hours after the
push, to the public repository.
For information on how to access the public repository
see http://dev.mysql.com/doc/mysql/en/installing-source-tree.html

ChangeSet
  1.1945 05/08/05 13:34:40 andrey@lmy004. +1 -0
  fix for bug #11733

  sql/sql_parse.cc
    1.458 05/08/05 13:34:29 andrey@lmy004. +23 -0
    add all modifying queries to the list of uc_update_queries which are forbidden in --read-only mode and are counted against the hourly quota

# This is a BitKeeper patch.  What follows are the unified diffs for the
# set of deltas contained in the patch.  The rest of the patch, the part
# that BitKeeper cares about, is below these diffs.
# User:	andrey
# Host:	lmy004.
# Root:	/home/andrey/mysql-5.0-test

--- 1.457/sql/sql_parse.cc	2005-08-03 12:13:59 +02:00
+++ 1.458/sql/sql_parse.cc	2005-08-05 13:34:29 +02:00
@@ -590,6 +590,21 @@
 {
   bzero((gptr) &uc_update_queries, sizeof(uc_update_queries));
 
+  uc_update_queries[SQLCOM_COMMIT]=1;
+  uc_update_queries[SQLCOM_ROLLBACK]=1;
+  uc_update_queries[SQLCOM_SAVEPOINT]=1;
+  uc_update_queries[SQLCOM_ROLLBACK_TO_SAVEPOINT]=1;
+  uc_update_queries[SQLCOM_CREATE_FUNCTION]=1;
+  uc_update_queries[SQLCOM_DROP_FUNCTION]=1;
+  uc_update_queries[SQLCOM_CREATE_USER]=1;
+  uc_update_queries[SQLCOM_RENAME_USER]=1;
+  uc_update_queries[SQLCOM_DROP_USER]=1;
+  uc_update_queries[SQLCOM_CREATE_PROCEDURE]=1;
+  uc_update_queries[SQLCOM_ALTER_PROCEDURE]=1;
+  uc_update_queries[SQLCOM_DROP_PROCEDURE]=1;
+  uc_update_queries[SQLCOM_CREATE_SPFUNCTION]=1;
+  uc_update_queries[SQLCOM_CREATE_TRIGGER]=1;
+  uc_update_queries[SQLCOM_DROP_TRIGGER]=1;
   uc_update_queries[SQLCOM_CREATE_TABLE]=1;
   uc_update_queries[SQLCOM_CREATE_INDEX]=1;
   uc_update_queries[SQLCOM_ALTER_TABLE]=1;
@@ -612,6 +627,14 @@
   uc_update_queries[SQLCOM_DROP_INDEX]=1;
   uc_update_queries[SQLCOM_CREATE_VIEW]=1;
   uc_update_queries[SQLCOM_DROP_VIEW]=1;
+  uc_update_queries[SQLCOM_REPAIR]=1;
+  uc_update_queries[SQLCOM_OPTIMIZE]=1;
+  uc_update_queries[SQLCOM_CHECK]=1;
+  uc_update_queries[SQLCOM_GRANT]=1;
+  uc_update_queries[SQLCOM_REVOKE]=1;
+  uc_update_queries[SQLCOM_REVOKE_ALL]=1;
+  //QQ What about SQLCOM_XA_COMMIT, SQLCOM_XA_ROLLBACK?
+  
 }
 
 bool is_update_query(enum enum_sql_command command)