List:Internals« Previous MessageNext Message »
From:svoj Date:August 2 2005 6:33am
Subject:bk commit into 4.0 tree (svoj:1.2127) BUG#11684
View as plain text  
Below is the list of changes that have just been committed into a local
4.0 repository of svoj. When svoj does a push these changes will
be propagated to the main repository and, within 24 hours after the
push, to the public repository.
For information on how to access the public repository
see http://dev.mysql.com/doc/mysql/en/installing-source-tree.html

ChangeSet
  1.2127 05/08/02 11:33:26 svoj@stripped +3 -0
  BUG#11684 fix.
  Repair crashes mysql when table has fulltext index.

  mysql-test/t/fulltext.test
    1.49 05/08/02 11:33:24 svoj@stripped +11 -0
    Test case for BUG#11684 - repair crashes mysql when table has fulltext index.

  mysql-test/r/fulltext.result
    1.50 05/08/02 11:33:24 svoj@stripped +8 -0
    Test case for BUG#11684 - repair crashes mysql when table has fulltext index.

  myisam/sort.c
    1.29 05/08/02 11:33:24 svoj@stripped +8 -6
    Use static ft_buf instead of dynamic mergebuf. Latter could be NULL if record has long words.

# This is a BitKeeper patch.  What follows are the unified diffs for the
# set of deltas contained in the patch.  The rest of the patch, the part
# that BitKeeper cares about, is below these diffs.
# User:	svoj
# Host:	svoj-laptop.mysql.com
# Root:	/home/svoj/devel/mysql/BUG11684/mysql-4.0

--- 1.28/myisam/sort.c	2003-04-28 21:05:55 +05:00
+++ 1.29/myisam/sort.c	2005-08-02 11:33:24 +05:00
@@ -532,13 +532,15 @@
 
       while (!got_error &&
 	     !my_b_read(&sinfo->tempfile_for_exceptions,(byte*)&key_length,
-			sizeof(key_length)) &&
-	     !my_b_read(&sinfo->tempfile_for_exceptions,(byte*)mergebuf,
-			(uint) key_length))
+			sizeof(key_length)))
       {
-	if (_mi_ck_write(info,sinfo->key,(uchar*) mergebuf,
-			 key_length - info->s->rec_reflength))
-	  got_error=1;
+        byte ft_buf[HA_FT_MAXLEN + HA_FT_WLEN + 10];
+        if (key_length > sizeof(ft_buf) ||
+            my_b_read(&sinfo->tempfile_for_exceptions, (byte*)ft_buf,
+                      (uint)key_length) ||
+            _mi_ck_write(info, sinfo->key, (uchar*)ft_buf,
+                         key_length - info->s->rec_reflength))
+          got_error=1;
       }
     }
   }

--- 1.49/mysql-test/r/fulltext.result	2005-02-16 13:13:01 +04:00
+++ 1.50/mysql-test/r/fulltext.result	2005-08-02 11:33:24 +05:00
@@ -321,3 +321,11 @@
 MATCH(a) AGAINST ('nosuchword')
 0
 DROP TABLE t1;
+CREATE TABLE t1 (a VARCHAR(30), FULLTEXT(a));
+INSERT INTO t1 VALUES('bbbbbbbbbbbbbbbbbbbbbbbbbbbbbb');
+SET myisam_repair_threads=2;
+REPAIR TABLE t1;
+Table	Op	Msg_type	Msg_text
+test.t1	repair	status	OK
+SET myisam_repair_threads=@@global.myisam_repair_threads;
+DROP TABLE t1;

--- 1.48/mysql-test/t/fulltext.test	2005-02-16 13:13:01 +04:00
+++ 1.49/mysql-test/t/fulltext.test	2005-08-02 11:33:24 +05:00
@@ -260,3 +260,14 @@
 INSERT INTO t1 VALUES ('testing ft_nlq_find_relevance');
 SELECT MATCH(a) AGAINST ('nosuchword') FROM t1;
 DROP TABLE t1;
+
+#
+# BUG#11684 - repair crashes mysql when table has fulltext index
+#
+
+CREATE TABLE t1 (a VARCHAR(30), FULLTEXT(a));
+INSERT INTO t1 VALUES('bbbbbbbbbbbbbbbbbbbbbbbbbbbbbb');
+SET myisam_repair_threads=2;
+REPAIR TABLE t1;
+SET myisam_repair_threads=@@global.myisam_repair_threads;
+DROP TABLE t1;
Thread
bk commit into 4.0 tree (svoj:1.2127) BUG#11684svoj2 Aug