Connector/NET commit: r113 - in branches/1.0: . TestSuite

[rburnett]

Modified:
   branches/1.0/CHANGES
   branches/1.0/TestSuite/DataReaderTests.cs
Log:
Bug #11873  	Invalid timestamp in query produces incorrect reader exception
Added timestamp.  The bug had already been fixed in a previous cset


Modified: branches/1.0/CHANGES
===================================================================
--- branches/1.0/CHANGES	2005-07-07 23:35:39 UTC (rev 112)
+++ branches/1.0/CHANGES	2005-07-12 21:47:36 UTC (rev 113)
@@ -1,3 +1,5 @@
+	Bugs fixed or addressed
+	-------------------------
 	Bug #8667  	OUT parameters are not being valued [fixed]
 	Bug #8574  	MySQLCommandBuilder unable to support inline functions [fixed]
 	Bug #8509  	MySqlDataAdapter.FillSchema does not interpret unsigned integer	[fixed]
@@ -3,7 +5,5 @@
 	Bug #8630  	Executing a query with the SchemaOnly option reads the entire resultset	[fixed]
 	Bug #7398  	MySqlParameterCollection doesn't allow parameters without filled in names [fixed]
-	Fixed problem parsing stored procedure parameter defs such as OUT val INT  UNSIGNED
 	Bug #7623  	Adding MySqlParameter causes error if MySqlDbType is Decimal [fixed]
-	Now supports the new decimal type introduced in 5.0.3
 	Bug #8929  	Timestamp values with a date > 10/29/9997 cause problems [fixed]
 	Bug #8514  	CURRENT_TIMESTAMP default not respected [fixed]
@@ -16,33 +16,33 @@
 	Bug #9722   Connector does not recognize parameters separated by a linefeed 
 	Bug #10281  Clone issue with MySqlConnection 
 	Bug #11450  Connector/Net, current database and stored procedures
-	Fixed bug where adding parameter objects that had been independently constructed did not work right.
 	Bug 	Bug #8228  	turkish character set causing the error [fixed]
-	
 	Bug #8387  	Connecting with NAMES and character_set_results can be up to 18 times slower.
 				Improved this by only issuing a SET NAMES if character_set_client or 
 				character_set_connection is different than what we are wanting.
-				
 	Bug #8382  	Commandbuilder does not handle queries to other databases than the default one-
 				fixed this one with the help of a patch from Henrik Johnson.
-						
 	Bug #10637 	Fail connect to specified MySql Hosts							
 				The problem was that we were  using BeginConnect/EndConnect to implement connect
 				timeout. Each one of these uses a worker thread from the .NET thread pool.  This
 				thread pool only has a default of 25 threads so on a very heavily loaded system,
 				it's possible it could run out.  Connect has now been recoded to not use a 
 				worker thread.
-					
 	Bug #11542  Call to Stored Procedure throws exception when SP has no arguments [fixed]
+	Bug #11550  Adding decimal parameters problem						[fixed]
+	Bug+	Bug+				All three of these bugs were related to the same problem					
+	Bug #11873 	Invalid timestamp in query produces incorrect reader exception [added test case, already fixed]
+	
+	Other changes
+	-------------
+	Fixed problem parsing stored procedure parameter defs such as OUT val INT  UNSIGNED
+	Now supports the new decimal type introduced in 5.0.3
+	Fixed bug where adding parameter objects that had been independently constructed did not work right.
+
 							
-	Bug #11294	Wrong data type getting values from grouping functions on integers 
-				with mysql-5 [this was fixed with earlier bug]
-							
-	Bug #11621 	connector does not support charset cp1250 [fixed]
-							
-	Bug #11550  	Adding decimal parameters problem [fixed]
-
 1-20-05 - Version 1.0.4  
 
 	Bug #7243 calling prepare causing exception [fixed]

Modified: branches/1.0/TestSuite/DataReaderTests.cs
===================================================================
--- branches/1.0/TestSuite/DataReaderTests.cs	2005-07-07 23:35:39 UTC (rev 112)
+++ branches/1.0/TestSuite/DataReaderTests.cs	2005-07-12 21:47:36 UTC (rev 113)
@@ -734,6 +734,53 @@
 			}
 		}
 
+		/// <summary>
+		/// Bug #9237  	MySqlDataReader.AffectedRecords not set to -1
+		/// </summary>
+		[Test]
+		public void AffectedRows()
+		{
+			MySqlCommand cmd = new MySqlCommand("SHOW TABLES", conn);
+			try 
+			{
+				using (MySqlDataReader reader = cmd.ExecuteReader()) 
+				{
+					reader.Read();
+					reader.Close();
+					Assert.AreEqual(-1, reader.RecordsAffected);
+				}
+			}
+			catch (Exception ex) 
+			{
+				Assert.Fail(ex.Message);
+			}
+		}
 
+		/// <summary>
+		/// Bug #11873  	Invalid timestamp in query produces incorrect reader exception
+		/// </summary>
+		[Test]
+		public void InvalidTimestamp() 
+		{
+			execSQL("DROP TABLE IF EXISTS test");
+			execSQL("CREATE TABLE test (tm TIMESTAMP)");
+			execSQL("INSERT INTO test VALUES (NULL)");
+
+			MySqlCommand cmd = new MySqlCommand("SELECT * FROM test WHERE tm = '7/1/2005 12:00:00 AM'", conn); 
+			MySqlDataReader reader = null;
+			try 
+			{
+				reader = cmd.ExecuteReader();
+			}
+			catch (Exception ex) 
+			{
+				Assert.Fail(ex.Message);
+			}
+			finally 
+			{
+				if (reader != null) reader.Close();
+			}
+		}
+
 	}
 }