bk commit into 5.0 tree (heikki:1.1872)

[Heikki Tuuri]

Below is the list of changes that have just been committed into a local
5.0 repository of heikki. When heikki does a push these changes will
be propagated to the main repository and, within 24 hours after the
push, to the public repository.
For information on how to access the public repository
see http://dev.mysql.com/doc/mysql/en/installing-source-tree.html

ChangeSet
  1.1872 05/07/02 00:39:47 heikki@stripped +1 -0
  row0sel.c:
    Optimize speed: no need to keep track of set new rec locks in a consistent read

  innobase/row/row0sel.c
    1.94 05/07/02 00:39:22 heikki@stripped +11 -3
    Optimize speed: no need to keep track of set new rec locks in a consistent read

# This is a BitKeeper patch.  What follows are the unified diffs for the
# set of deltas contained in the patch.  The rest of the patch, the part
# that BitKeeper cares about, is below these diffs.
# User:	heikki
# Host:	hundin.mysql.fi
# Root:	/home/heikki/mysql-5.0

--- 1.93/innobase/row/row0sel.c	Fri Jul  1 20:41:27 2005
+++ 1.94/innobase/row/row0sel.c	Sat Jul  2 00:39:22 2005
@@ -3150,7 +3150,9 @@
 	is set. Then we are able to remove the record locks set here on an
 	individual row. */
 
-	if (srv_locks_unsafe_for_binlog) {
+	if (srv_locks_unsafe_for_binlog
+	    && prebuilt->select_lock_type != LOCK_NONE) {
+
 		trx_reset_new_rec_lock_info(trx);
 	}
 
@@ -3793,7 +3795,9 @@
 		not a consistent read which might see an earlier version
 		of a non-clustered index record */
 
-		if (srv_locks_unsafe_for_binlog) {
+		if (srv_locks_unsafe_for_binlog
+	    	    && prebuilt->select_lock_type != LOCK_NONE) {
+
 			/* No need to keep a lock on a delete-marked record
 			if we do not want to use next-key locking. */
 
@@ -3845,7 +3849,9 @@
 
 			/* The record is delete marked: we can skip it */
 
-			if (srv_locks_unsafe_for_binlog) {
+			if (srv_locks_unsafe_for_binlog
+	    		    && prebuilt->select_lock_type != LOCK_NONE) {
+
 				/* No need to keep a lock on a delete-marked
 				record if we do not want to use next-key
 				locking. */
@@ -4013,6 +4019,8 @@
 	thr->lock_state = QUE_THR_LOCK_ROW;
 
 	if (row_mysql_handle_errors(&err, trx, thr, NULL)) {
+		/* It was a lock wait, and it ended */
+
 		thr->lock_state = QUE_THR_LOCK_NOLOCK;
 		mtr_start(&mtr);