From: Date: July 1 2005 12:01pm
Subject: bk commit into 4.1 tree (lars:1.2329) BUG#11678
List-Archive: http://lists.mysql.com/internals/26581
X-Bug: 11678
Message-Id: <20050701100109.6090011601C@localhost>

Below is the list of changes that have just been committed into a local
4.1 repository of lars. When lars does a push these changes will
be propagated to the main repository and, within 24 hours after the
push, to the public repository.
For information on how to access the public repository
see http://dev.mysql.com/doc/mysql/en/installing-source-tree.html

ChangeSet
  1.2329 05/07/01 12:01:00 lars@stripped +1 -0
  BUG#11678: mysqldump --master-data should fail if master binlog disabled

  client/mysqldump.c
    1.193 05/07/01 12:00:54 lars@stripped +9 -0
    Add error message in case master does not have binlogging enabled

# This is a BitKeeper patch.  What follows are the unified diffs for the
# set of deltas contained in the patch.  The rest of the patch, the part
# that BitKeeper cares about, is below these diffs.
# User:	lars
# Host:	dhcppc0.ver
# Root:	/home/bk/b11678-mysql-4.1

--- 1.192/client/mysqldump.c	2005-06-27 19:30:53 +02:00
+++ 1.193/client/mysqldump.c	2005-07-01 12:00:54 +02:00
@@ -2356,6 +2356,7 @@
     row = mysql_fetch_row(master);
     if (row && row[0] && row[1])
     {
+      /* SHOW MASTER STATUS reports file and position */
       if (opt_comments)
         fprintf(md_result_file,
                 "\n--\n-- Position to start replication or point-in-time "
@@ -2364,6 +2365,14 @@
               "%sCHANGE MASTER TO MASTER_LOG_FILE='%s', MASTER_LOG_POS=%s;\n",
               comment_prefix, row[0], row[1]); 
       check_io(md_result_file);
+    }
+    else if (!ignore_errors)
+    {
+      /* SHOW MASTER STATUS reports nothing and --force is not enabled */
+      my_printf_error(0, "Error: Binlogging on server not active", 
+		      MYF(0), mysql_error(mysql_con));
+      mysql_free_result(master);
+      return 1;
     }
     mysql_free_result(master);
   }