Below is the list of changes that have just been committed into a local
5.0 repository of kostja. When kostja does a push these changes will
be propagated to the main repository and, within 24 hours after the
push, to the public repository.
For information on how to access the public repository
see http://dev.mysql.com/doc/mysql/en/installing-source-tree.html
ChangeSet
1.1983 05/06/28 22:49:14 konstantin@stripped +2 -0
Fixed comments.
sql/sp_head.cc
1.150 05/06/28 22:49:07 konstantin@stripped +0 -7
An obsolete comment removed.
sql/opt_range.cc
1.177 05/06/28 22:49:07 konstantin@stripped +1 -1
comment fixed.
# This is a BitKeeper patch. What follows are the unified diffs for the
# set of deltas contained in the patch. The rest of the patch, the part
# that BitKeeper cares about, is below these diffs.
# User: konstantin
# Host: dragonfly.local
# Root: /opt/local/work/mysql-5.0-root
--- 1.176/sql/opt_range.cc 2005-06-28 20:52:08 +04:00
+++ 1.177/sql/opt_range.cc 2005-06-28 22:49:07 +04:00
@@ -3702,7 +3702,7 @@
/*
We need to restore the runtime mem_root of the thread in this
- function becuase it evaluates the value of its argument, while
+ function because it evaluates the value of its argument, while
the argument can be any, e.g. a subselect. The subselect
items, in turn, assume that all the memory allocated during
the evaluation has the same life span as the item itself.
--- 1.149/sql/sp_head.cc 2005-06-23 20:22:02 +04:00
+++ 1.150/sql/sp_head.cc 2005-06-28 22:49:07 +04:00
@@ -1474,13 +1474,6 @@
they want to store some value in local variable, pass return value and
etc... So their life time should be longer than one instruction.
- Probably we can call destructors for most of them then we are leaving
- routine. But this won't help much as they are allocated in main query
- MEM_ROOT anyway. So they all go to global thd->free_list.
-
- May be we can use some other MEM_ROOT for this purprose ???
-
- What else should we do for cleanup ?
cleanup_items() is called in sp_head::execute()
*/
return res;
| Thread |
|---|
| • bk commit into 5.0 tree (konstantin:1.1983) | konstantin | 28 Jun |