bk commit into 5.0 tree (msvensson:1.1972) BUG#10466

[msvensson]

Below is the list of changes that have just been committed into a local
5.0 repository of msvensson. When msvensson does a push these changes will
be propagated to the main repository and, within 24 hours after the
push, to the public repository.
For information on how to access the public repository
see http://dev.mysql.com/doc/mysql/en/installing-source-tree.html

ChangeSet
  1.1972 05/06/20 12:11:52 msvensson@neptunus.(none) +1 -0
  BUG#10466 Datatype "timestamp" displays "YYYYMMDDHHMMSS" irrespective of display sizes.
    - Use buffer for printing error message 

  sql/sql_parse.cc
    1.454 05/06/20 12:11:45 msvensson@neptunus.(none) +3 -3
    Use buffer for string

# This is a BitKeeper patch.  What follows are the unified diffs for the
# set of deltas contained in the patch.  The rest of the patch, the part
# that BitKeeper cares about, is below these diffs.
# User:	msvensson
# Host:	neptunus.(none)
# Root:	/home/msvensson/mysql/bug10466

--- 1.453/sql/sql_parse.cc	2005-06-20 12:08:55 +02:00
+++ 1.454/sql/sql_parse.cc	2005-06-20 12:11:45 +02:00
@@ -5464,9 +5464,9 @@
        In other words, for declarations such as TIMESTAMP(2), TIMESTAMP(4),
        and so on, the display width is ignored.
     */
-    String str;
-    str.append("TIMESTAMP");
-    str.append("(");
+    char buff[32];
+    String str(buff,(uint32) sizeof(buff), system_charset_info);
+    str.append("TIMESTAMP(");
     str.append(length);
     str.append(")");
     push_warning_printf(thd,MYSQL_ERROR::WARN_LEVEL_WARN,