List:Internals« Previous MessageNext Message »
From:Stewart Smith Date:June 15 2005 6:59am
Subject:bk commit into 4.1 tree (stewart:1.2295) BUG#11132
View as plain text  
Below is the list of changes that have just been committed into a local
4.1 repository of stewart. When stewart does a push these changes will
be propagated to the main repository and, within 24 hours after the
push, to the public repository.
For information on how to access the public repository
see http://dev.mysql.com/doc/mysql/en/installing-source-tree.html

ChangeSet
  1.2295 05/06/15 14:58:53 stewart@stripped +1 -0
  BUG#11132 Connections stuck in CLOSE_WAIT
  
  In 4.1 (it is different in 5.0), we do not use the mgm connection after fetching the
  configuration (and if we did, we would have to have calls to check the connection and
  reconnect if needed - in case the mgm server had restarted) so we can disconnect after
  first use.
  
  This means we won't have connections stuck in CLOSE_WAIT when the mgm server shuts down.

  ndb/src/common/mgmcommon/ConfigRetriever.cpp
    1.24 05/06/15 14:58:45 stewart@stripped +3 -1
    Disconnect from management server after configuration is fetched.

# This is a BitKeeper patch.  What follows are the unified diffs for the
# set of deltas contained in the patch.  The rest of the patch, the part
# that BitKeeper cares about, is below these diffs.
# User:	stewart
# Host:	kennedy.(none)
# Root:	/home/stewart/Documents/MySQL/4.1/bug11132

--- 1.23/ndb/src/common/mgmcommon/ConfigRetriever.cpp	2005-02-17 06:46:28 +11:00
+++ 1.24/ndb/src/common/mgmcommon/ConfigRetriever.cpp	2005-06-15 14:58:45 +10:00
@@ -138,7 +138,9 @@
     setError(CR_ERROR, ndb_mgm_get_latest_error_desc(m_handle));
     return 0;
   }
-  
+
+  ndb_mgm_disconnect(m_handle);
+
   return conf;
 }
 
Thread
bk commit into 4.1 tree (stewart:1.2295) BUG#11132Stewart Smith15 Jun