List:Internals« Previous MessageNext Message »
From:Marko Mäkelä Date:June 10 2005 11:01am
Subject:bk commit into 5.0 tree (marko:1.1872)
View as plain text  
Below is the list of changes that have just been committed into a local
5.0 repository of marko. When marko does a push these changes will
be propagated to the main repository and, within 24 hours after the
push, to the public repository.
For information on how to access the public repository
see http://dev.mysql.com/doc/mysql/en/installing-source-tree.html

ChangeSet
  1.1872 05/06/10 14:00:53 marko@stripped +2 -0
  InnoDB: minor clean-up in os0file

  innobase/os/os0file.c
    1.104 05/06/10 14:00:43 marko@stripped +10 -8
    Remove unused function os_aio_all_slots_free() from non-debug builds.
    Add static qualifiers to module-global variables.

  innobase/include/os0file.h
    1.35 05/06/10 14:00:42 marko@stripped +3 -0
    Remove unused function os_aio_all_slots_free() from non-debug builds.

# This is a BitKeeper patch.  What follows are the unified diffs for the
# set of deltas contained in the patch.  The rest of the patch, the part
# that BitKeeper cares about, is below these diffs.
# User:	marko
# Host:	hundin.mysql.fi
# Root:	/home/marko/mysql-5.0

--- 1.34/innobase/include/os0file.h	Wed Apr  6 21:29:10 2005
+++ 1.35/innobase/include/os0file.h	Fri Jun 10 14:00:42 2005
@@ -688,6 +688,8 @@
 void
 os_aio_refresh_stats(void);
 /*======================*/
+
+#ifdef UNIV_DEBUG
 /**************************************************************************
 Checks that all slots in the system have been freed, that is, there are
 no pending io operations. */
@@ -695,6 +697,7 @@
 ibool
 os_aio_all_slots_free(void);
 /*=======================*/
+#endif /* UNIV_DEBUG */
 
 /***********************************************************************
 This function returns information about the specified file */

--- 1.103/innobase/os/os0file.c	Wed Apr  6 21:29:10 2005
+++ 1.104/innobase/os/os0file.c	Fri Jun 10 14:00:43 2005
@@ -133,17 +133,17 @@
 
 /* The aio arrays for non-ibuf i/o and ibuf i/o, as well as sync aio. These
 are NULL when the module has not yet been initialized. */
-os_aio_array_t*	os_aio_read_array	= NULL;
-os_aio_array_t*	os_aio_write_array	= NULL;
-os_aio_array_t*	os_aio_ibuf_array	= NULL;
-os_aio_array_t*	os_aio_log_array	= NULL;
-os_aio_array_t*	os_aio_sync_array	= NULL;
+static os_aio_array_t*	os_aio_read_array	= NULL;
+static os_aio_array_t*	os_aio_write_array	= NULL;
+static os_aio_array_t*	os_aio_ibuf_array	= NULL;
+static os_aio_array_t*	os_aio_log_array	= NULL;
+static os_aio_array_t*	os_aio_sync_array	= NULL;
 
-ulint	os_aio_n_segments	= ULINT_UNDEFINED;
+static ulint	os_aio_n_segments	= ULINT_UNDEFINED;
 
 /* If the following is TRUE, read i/o handler threads try to
 wait until a batch of new read requests have been posted */
-ibool	os_aio_recommend_sleep_for_read_threads	= FALSE;
+static ibool	os_aio_recommend_sleep_for_read_threads	= FALSE;
 
 ulint	os_n_file_reads		= 0;
 ulint	os_bytes_read_since_printout = 0;
@@ -158,7 +158,7 @@
 
 /* The mutex protecting the following counts of pending pread and pwrite
 operations */
-os_mutex_t os_file_count_mutex;
+static os_mutex_t os_file_count_mutex;
 ulint	os_file_n_pending_preads  = 0;
 ulint	os_file_n_pending_pwrites = 0;
 
@@ -4182,6 +4182,7 @@
 	os_last_printout = time(NULL);
 }
 
+#ifdef UNIV_DEBUG
 /**************************************************************************
 Checks that all slots in the system have been freed, that is, there are
 no pending io operations. */
@@ -4241,3 +4242,4 @@
 
 	return(FALSE);
 }
+#endif /* UNIV_DEBUG */
Thread
bk commit into 5.0 tree (marko:1.1872)Marko Mäkelä10 Jun