bk commit into 5.1 tree (stewart:1.1910)

[Stewart Smith]

Below is the list of changes that have just been committed into a local
5.1 repository of stewart. When stewart does a push these changes will
be propagated to the main repository and, within 24 hours after the
push, to the public repository.
For information on how to access the public repository
see http://dev.mysql.com/doc/mysql/en/installing-source-tree.html

ChangeSet
  1.1910 05/06/01 22:45:57 stewart@stripped +1 -0
  WL#2325 NDB Injector thread
  
  add big warning about shutting down NDB handler before MyISAM handler

  sql/handler.cc
    1.174 05/06/01 22:45:50 stewart@stripped +10 -0
    Add warning about how NDB should be shut down before MyISAM
    
    (serg suggested it, so that this will be preserved when loadable storage engines
    are implemented)

# This is a BitKeeper patch.  What follows are the unified diffs for the
# set of deltas contained in the patch.  The rest of the patch, the part
# that BitKeeper cares about, is below these diffs.
# User:	stewart
# Host:	kennedy.(none)
# Root:	/home/stewart/Documents/MySQL/5.1/wl2325

--- 1.173/sql/handler.cc	2005-06-01 09:25:26 +10:00
+++ 1.174/sql/handler.cc	2005-06-01 22:45:50 +10:00
@@ -476,6 +476,16 @@
 int ha_panic(enum ha_panic_function flag)
 {
   int error=0;
+
+  /**
+   * BIG WARNING:
+   * Order of shutdown matters!
+   * With NDB Replication, we have a thread that both
+   * injects rows into the binlog, and writes information
+   * about NDB replication to a MyISAM table. Hence, we must
+   * shut down NDB *before* MyISAM.
+   * Otherwise we crash.
+   */
 #ifdef HAVE_NDBCLUSTER_DB
   if (have_ndbcluster == SHOW_OPTION_YES)
     error|=ndbcluster_end();