bk commit into 4.1 tree (mskold:1.2241) BUG#9813

[Martin Skold]

Below is the list of changes that have just been committed into a local
4.1 repository of marty. When marty does a push these changes will
be propagated to the main repository and, within 24 hours after the
push, to the public repository.
For information on how to access the public repository
see http://dev.mysql.com/doc/mysql/en/installing-source-tree.html

ChangeSet
  1.2241 05/05/07 22:04:52 mskold@stripped +2 -0
  bug#9813: Post review fixes

  sql/ha_ndbcluster.cc
    1.152 05/05/07 22:04:26 mskold@stripped +4 -0
    bug#9813: Post review fixes

  ndb/src/ndbapi/Ndb.cpp
    1.42 05/05/07 22:04:26 mskold@stripped +6 -5
    bug#9813: Post review fixes

# This is a BitKeeper patch.  What follows are the unified diffs for the
# set of deltas contained in the patch.  The rest of the patch, the part
# that BitKeeper cares about, is below these diffs.
# User:	mskold
# Host:	blowfish.ndb.mysql.com
# Root:	/usr/local/home/marty/MySQL/mysql-4.1

--- 1.41/ndb/src/ndbapi/Ndb.cpp	Wed Apr 13 14:08:50 2005
+++ 1.42/ndb/src/ndbapi/Ndb.cpp	Sat May  7 22:04:26 2005
@@ -730,7 +730,7 @@
     DBUG_RETURN(~(Uint64)0);
   const NdbTableImpl *table= info->m_table_impl;
   Uint64 tupleId = getTupleIdFromNdb(table->m_tableId, cacheSize);
-  DBUG_PRINT("info", ("value %u", tupleId));
+  DBUG_PRINT("info", ("value %ul", (ulong) tupleId));
   DBUG_RETURN(tupleId);
 }
 
@@ -742,7 +742,7 @@
     DBUG_RETURN(~(Uint64)0);
   const NdbTableImpl* table = & NdbTableImpl::getImpl(*aTable);
   Uint64 tupleId = getTupleIdFromNdb(table->m_tableId, cacheSize);
-  DBUG_PRINT("info", ("value %u", tupleId));
+  DBUG_PRINT("info", ("value %ul", (ulong) tupleId));
   DBUG_RETURN(tupleId);
 }
 
@@ -762,7 +762,8 @@
   if ( theFirstTupleId[aTableId] != theLastTupleId[aTableId] )
   {
     theFirstTupleId[aTableId]++;
-    DBUG_PRINT("info", ("next cached value %u", theFirstTupleId[aTableId]));
+    DBUG_PRINT("info", ("next cached value %ul", 
+                        (ulong) theFirstTupleId[aTableId]));
     DBUG_RETURN(theFirstTupleId[aTableId]);
   }
   else // theFirstTupleId == theLastTupleId
@@ -783,7 +784,7 @@
     DBUG_RETURN(~(Uint64)0);
   }
   Uint64 tupleId = readTupleIdFromNdb(table->m_tableId);
-  DBUG_PRINT("info", ("value %u", tupleId));
+  DBUG_PRINT("info", ("value %ul", (ulong) tupleId));
   DBUG_RETURN(tupleId);
 }
 
@@ -795,7 +796,7 @@
     DBUG_RETURN(~(Uint64)0);
   const NdbTableImpl* table = & NdbTableImpl::getImpl(*aTable);
   Uint64 tupleId = readTupleIdFromNdb(table->m_tableId);
-  DBUG_PRINT("info", ("value %u", tupleId));
+  DBUG_PRINT("info", ("value %ul", (ulong) tupleId));
   DBUG_RETURN(tupleId);
 }
 

--- 1.151/sql/ha_ndbcluster.cc	Fri Apr 29 11:37:15 2005
+++ 1.152/sql/ha_ndbcluster.cc	Sat May  7 22:04:26 2005
@@ -3003,8 +3003,10 @@
   
   m_rows_inserted= (ha_rows) 0;
   if (rows == (ha_rows) 0)
+  {
     /* We don't know how many will be inserted, guess */
     m_rows_to_insert= m_autoincrement_prefetch;
+  }
   else
     m_rows_to_insert= rows; 
 
@@ -4021,8 +4023,10 @@
   Ndb *ndb= get_ndb();
   
   if (m_rows_inserted > m_rows_to_insert)
+  {
     /* We guessed too low */
     m_rows_to_insert+= m_autoincrement_prefetch;
+  }
   int cache_size= 
     (int)
     (m_rows_to_insert - m_rows_inserted < m_autoincrement_prefetch) ?