bk commit into 5.0 tree (konstantin:1.1907) BUG#5673

[konstantin]

Below is the list of changes that have just been committed into a local
5.0 repository of kostja. When kostja does a push these changes will
be propagated to the main repository and, within 24 hours after the
push, to the public repository.
For information on how to access the public repository
see http://dev.mysql.com/doc/mysql/en/installing-source-tree.html

ChangeSet
  1.1907 05/04/28 13:03:06 konstantin@stripped +2 -0
  A test case for Bug#5673 "Rounding problem in 4.0.21 inserting decimal 
  value into a char field": the patch submitted for the bug a while
  ago has never been reviewed or approved to push into 4.0. Decimal
  support in 5.0 resolves the issue.
  Adding the test case and closing the bug report.

  mysql-test/t/type_decimal.test
    1.23 05/04/28 13:03:00 konstantin@stripped +28 -0
    A test case for Bug#5673 "Rounding problem in 4.0.21 inserting decimal 
    value into a char field"

  mysql-test/r/type_decimal.result
    1.31 05/04/28 13:03:00 konstantin@stripped +20 -0
    Bug#5673: test results fixed.

# This is a BitKeeper patch.  What follows are the unified diffs for the
# set of deltas contained in the patch.  The rest of the patch, the part
# that BitKeeper cares about, is below these diffs.
# User:	konstantin
# Host:	dragonfly.local
# Root:	/opt/local/work/mysql-5.0-root

--- 1.30/mysql-test/r/type_decimal.result	2005-04-15 02:14:27 +04:00
+++ 1.31/mysql-test/r/type_decimal.result	2005-04-28 13:03:00 +04:00
@@ -764,3 +764,23 @@
 PS, 1.0 in parameter    	1.0
 deallocate prepare stmt;
 drop table t1;
+create table t1 (
+strippedproductid char(15) not null default '',
+zlevelprice decimal(10,2) default null,
+primary key (strippedproductid)
+);
+create table t2 (
+productid char(15) not null default '',
+zlevelprice char(21) default null,
+primary key (productid)
+);
+insert into t1 values ('002trans','49.99');
+insert into t1 values ('003trans','39.98');
+insert into t1 values ('004trans','31.18');
+insert INTO t2 SELECT * FROM t1;
+select * from t2;
+productid	zlevelprice
+002trans	49.99
+003trans	39.98
+004trans	31.18
+drop table t1, t2;

--- 1.22/mysql-test/t/type_decimal.test	2005-04-15 02:14:27 +04:00
+++ 1.23/mysql-test/t/type_decimal.test	2005-04-28 13:03:00 +04:00
@@ -343,3 +343,31 @@
 select * from t1;
 deallocate prepare stmt;
 drop table t1;
+
+#
+# A test case for Bug#5673 "Rounding problem in 4.0.21 inserting decimal
+# value into a char field": this is a regression bug in 4.0 tree caused by
+# a fix for some other decimal conversion issue. The patch never was
+# approved to get into 4.0 (maybe because it was considered too intrusive)
+#
+
+create table t1 (
+  strippedproductid char(15) not null default '',
+  zlevelprice decimal(10,2) default null,
+  primary key (strippedproductid)
+);
+
+create table t2 (
+  productid char(15) not null default '',
+  zlevelprice char(21) default null,
+  primary key (productid)
+);
+
+insert into t1 values ('002trans','49.99');
+insert into t1 values ('003trans','39.98');
+insert into t1 values ('004trans','31.18');
+
+insert INTO t2 SELECT * FROM t1;
+
+select * from t2; 
+drop table t1, t2;