bk commit into 4.1 tree (heikki:1.2177)

[Heikki Tuuri]

Below is the list of changes that have just been committed into a local
4.1 repository of heikki. When heikki does a push these changes will
be propagated to the main repository and, within 24 hours after the
push, to the public repository.
For information on how to access the public repository
see http://dev.mysql.com/doc/mysql/en/installing-source-tree.html

ChangeSet
  1.2177 05/04/13 15:49:28 heikki@stripped +1 -0
  row0sel.c:
    Do not test the value of err if the lock operation was skipped because innodb_logs_unsafe_for_binlog was TRUE; though this did not cause any bugs visible to the user, because err is inited to DB_SUCCESS at the start of the function row_search_for_mysql()

  innobase/row/row0sel.c
    1.68 05/04/13 15:49:11 heikki@stripped +12 -12
    Do not test the value of err if the lock operation was skipped because innodb_logs_unsafe_for_binlog was TRUE; though this did not cause any bugs visible to the user, because err is inited to DB_SUCCESS at the start of the function row_search_for_mysql()

# This is a BitKeeper patch.  What follows are the unified diffs for the
# set of deltas contained in the patch.  The rest of the patch, the part
# that BitKeeper cares about, is below these diffs.
# User:	heikki
# Host:	hundin.mysql.fi
# Root:	/home/heikki/mysql-4.1

--- 1.67/innobase/row/row0sel.c	Wed Apr  6 10:27:08 2005
+++ 1.68/innobase/row/row0sel.c	Wed Apr 13 15:49:11 2005
@@ -3305,12 +3305,12 @@
 				err = sel_set_rec_lock(rec, index,
 						prebuilt->select_lock_type,
 						LOCK_ORDINARY, thr);
-			}
-
-			if (err != DB_SUCCESS) {
+				if (err != DB_SUCCESS) {
 
-				goto lock_wait_or_error;
+					goto lock_wait_or_error;
+				}
 			}
+
 		}
 		/* A page supremum record cannot be in the result set: skip
 		it now that we have placed a possible lock on it */
@@ -3413,12 +3413,12 @@
 					err = sel_set_rec_lock(rec, index,
 						prebuilt->select_lock_type,
 						LOCK_GAP, thr);
-				}
-
-				if (err != DB_SUCCESS) {
+					if (err != DB_SUCCESS) {
 
-					goto lock_wait_or_error;
+						goto lock_wait_or_error;
+					}
 				}
+
 			}
 
 			btr_pcur_store_position(pcur, &mtr);
@@ -3446,12 +3446,12 @@
 					err = sel_set_rec_lock(rec, index,
 						prebuilt->select_lock_type,
 						LOCK_GAP, thr);
-				}
+					if (err != DB_SUCCESS) {
 
-				if (err != DB_SUCCESS) {
-
-					goto lock_wait_or_error;
+						goto lock_wait_or_error;
+					}
 				}
+
 			}
 
 			btr_pcur_store_position(pcur, &mtr);