From: Date: April 7 2005 3:42pm
Subject: bk commit into 5.0 tree (sergefp:1.1868) BUG#8877
List-Archive: http://lists.mysql.com/internals/23757
X-Bug: 8877
Message-Id: <20050407134237.8D2C937BB5@newbox.mylan>

Below is the list of changes that have just been committed into a local
5.0 repository of psergey. When psergey does a push these changes will
be propagated to the main repository and, within 24 hours after the
push, to the public repository.
For information on how to access the public repository
see http://dev.mysql.com/doc/mysql/en/installing-source-tree.html

ChangeSet
  1.1868 05/04/07 17:42:32 sergefp@stripped +1 -0
  BUG#8877: Post-merge fixes.

  sql/sql_select.cc
    1.310 05/04/07 17:42:27 sergefp@stripped +9 -6
    BUG#8877: Post-merge fixes.

# This is a BitKeeper patch.  What follows are the unified diffs for the
# set of deltas contained in the patch.  The rest of the patch, the part
# that BitKeeper cares about, is below these diffs.
# User:	sergefp
# Host:	newbox.mylan
# Root:	/home/psergey/mysql-5.0-bug8877-merge

--- 1.309/sql/sql_select.cc	2005-04-05 03:36:13 +04:00
+++ 1.310/sql/sql_select.cc	2005-04-07 17:42:27 +04:00
@@ -2231,6 +2231,8 @@
         if (s->dependent & table->map)
           s->dependent |= table->reginfo.join_tab->dependent;
       }
+      if (s->dependent)
+        s->table->maybe_null= 1;
     }
     /* Catch illegal cross references for outer joins */
     for (i= 0, s= stat ; i < table_count ; i++, s++)
@@ -2623,6 +2625,7 @@
 
 static void
 add_key_field(KEY_FIELD **key_fields,uint and_level, Item_func *cond,
+	      Field *field, bool eq_func, Item **value, uint num_values,
 	      table_map usable_tables)
 {
   uint exists_optimize= 0;
@@ -2758,7 +2761,7 @@
 
 static void
 add_key_equal_fields(KEY_FIELD **key_fields, uint and_level,
-                     COND *cond, Item_field *field_item,
+                     Item_func *cond, Item_field *field_item,
                      bool eq_func, Item **val,
                      uint num_values, table_map usable_tables)
 {
@@ -2899,7 +2902,7 @@
       */   
       while ((item= it++))
       {
-        add_key_field(key_fields, *and_level, cond, item->field,
+        add_key_field(key_fields, *and_level, cond_func, item->field,
                       TRUE, &const_item, 1, usable_tables);
       }
     }
@@ -2919,7 +2922,7 @@
         {
           if (!field->eq(item->field))
           {
-            add_key_field(key_fields, *and_level, cond, field,
+            add_key_field(key_fields, *and_level, cond_func, field,
                           TRUE, (Item **) &item, 1, usable_tables);
           }
         }
@@ -3139,7 +3142,7 @@
       {
         NESTED_JOIN *nested_join= embedding->nested_join;
         if (nested_join->join_list.head() == tab)
-          add_key_fields(join_tab, &end, &and_level, embedding->on_expr,
+          add_key_fields(&end, &and_level, embedding->on_expr,
                          nested_join->used_tables);
       }
     }
@@ -5174,7 +5177,7 @@
 
           null_rej->quick_fix_field();
           DBUG_EXECUTE("where",print_where(null_rej,
-                                           referred_tab->table->table_name););
+                                           referred_tab->table->alias););
           add_cond_and_fix(&referred_tab->select_cond, null_rej);
         }
       }
@@ -5454,7 +5457,7 @@
           tab->select_cond= sel->cond= NULL;
 
 	sel->head=tab->table;
-	DBUG_EXECUTE("where",print_where(tmp,tab->table->table_name););
+	DBUG_EXECUTE("where",print_where(tmp,tab->table->alias););
 	if (tab->quick)
 	{
 	  /* Use quick key read if it's a constant and it's not used