From: Date: March 21 2005 11:07am
Subject: bk commit into 4.1 tree (msvensson:1.2136) BUG#9072
List-Archive: http://lists.mysql.com/internals/23223
X-Bug: 9072
Message-Id: <20050321100735.9AF6B25E084@localhost.localdomain>

Below is the list of changes that have just been committed into a local
4.1 repository of msvensson. When msvensson does a push these changes will
be propagated to the main repository and, within 24 hours after the
push, to the public repository.
For information on how to access the public repository
see http://dev.mysql.com/doc/mysql/en/installing-source-tree.html

ChangeSet
  1.2136 05/03/21 11:07:31 msvensson@neptunus.(none) +3 -0
  BUG#9072 'Max_error_count' system variable cannot be set to zero
   - Chaned min value in mysqld.cc
   - Added testcase to warnings.test

  sql/mysqld.cc
    1.561 05/03/21 11:07:28 msvensson@neptunus.(none) +1 -1
    Change min value of max_error_count from 1 to 0

  mysql-test/t/warnings.test
    1.19 05/03/21 11:07:28 msvensson@neptunus.(none) +13 -0
    Added testcase for testing max and min value of max_error_count

  mysql-test/r/warnings.result
    1.29 05/03/21 11:07:28 msvensson@neptunus.(none) +19 -0
    Added testcase for testing max and min value of max_error_count

# This is a BitKeeper patch.  What follows are the unified diffs for the
# set of deltas contained in the patch.  The rest of the patch, the part
# that BitKeeper cares about, is below these diffs.
# User:	msvensson
# Host:	neptunus.(none)
# Root:	/home/msvensson/mysql/mysql-4.1

--- 1.560/sql/mysqld.cc	2005-03-09 13:41:50 +01:00
+++ 1.561/sql/mysqld.cc	2005-03-21 11:07:28 +01:00
@@ -5053,7 +5053,7 @@
    "Max number of errors/warnings to store for a statement.",
    (gptr*) &global_system_variables.max_error_count,
    (gptr*) &max_system_variables.max_error_count,
-   0, GET_ULONG, REQUIRED_ARG, DEFAULT_ERROR_COUNT, 1, 65535, 0, 1, 0},
+   0, GET_ULONG, REQUIRED_ARG, DEFAULT_ERROR_COUNT, 0, 65535, 0, 1, 0},
   {"max_heap_table_size", OPT_MAX_HEP_TABLE_SIZE,
    "Don't allow creation of heap tables bigger than this.",
    (gptr*) &global_system_variables.max_heap_table_size,

--- 1.18/mysql-test/t/warnings.test	2005-02-23 18:18:15 +01:00
+++ 1.19/mysql-test/t/warnings.test	2005-03-21 11:07:28 +01:00
@@ -97,6 +97,19 @@
 select @@warning_count;
 --enable_ps_protocol
 
+# Bug#9072
+set max_error_count=0;
+show variables like 'max_error_count';
+update t1 set b='hi';
+--disable_ps_protocol
+select @@warning_count;
+--enable_ps_protocol
+show warnings;
+set max_error_count=65535;
+show variables like 'max_error_count';
+set max_error_count=10;
+show variables like 'max_error_count';
+
 #
 # Test for handler type
 #

--- 1.28/mysql-test/r/warnings.result	2005-02-23 18:18:15 +01:00
+++ 1.29/mysql-test/r/warnings.result	2005-03-21 11:07:28 +01:00
@@ -142,6 +142,25 @@
 select @@warning_count;
 @@warning_count
 50
+set max_error_count=0;
+show variables like 'max_error_count';
+Variable_name	Value
+max_error_count	0
+update t1 set b='hi';
+Warnings:
+select @@warning_count;
+@@warning_count
+50
+show warnings;
+Level	Code	Message
+set max_error_count=65535;
+show variables like 'max_error_count';
+Variable_name	Value
+max_error_count	65535
+set max_error_count=10;
+show variables like 'max_error_count';
+Variable_name	Value
+max_error_count	10
 drop table t1;
 create table t1 (id int) engine=isam;
 Warnings: