Mikael Fridh wrote:
> Hi,
>
> Mats Kindahl wrote:
>> ChangeSet
>> 1.2074 05/03/08 18:05:19 mats@stripped +2 -0
>> Bug#8368: Added --slave-data option to mysqldump that will allow a
>> slave to be cloned. The option will append a CHANGE MASTER statement
>> to the output with the host, port, log file, and log pos of the slave.
>> + for (f = 0 ; f < slave->field_count ; ++f)
>> + {
>> + if (strcmp(slave->fields[f].name, "Master_Host") == 0)
>> + host_idx = f;
>> + else if (strcmp(slave->fields[f].name, "Master_Port") == 0)
>> + port_idx = f;
>> + else if (strcmp(slave->fields[f].name, "Master_Log_File") == 0)
>> + log_file_idx = f;
>> + else if (strcmp(slave->fields[f].name,
>> "Exec_master_log_pos") == 0)
>> + log_pos_idx = f;
>> + }
>
> Shouldn't this be Relay_Master_Log_File instead of Master_Log_File?
>
> I probably fooled you in my original patch idea by using the wrong field.
>
You propably did. I'll check to make sure that there's no problem.
> btw, will this reach the 4.1 tree if it's accepted in 4.0 review?
Yes. We are moving all patches to 4.0 up to 4.1 and further to 5.0.
Right now, however, it seems as if this patch will not go into 4.0,
though. We are only submitting bug-fixes to 4.0 and any new features,
such as this one, go into 4.1 (and further into 5.0).
Best wishes,
Mats Kindahl
--
Mats Kindahl
Replication Team
MySQL AB, www.mysql.com
