bk commit into 4.0 tree (mats:1.2066)

[Mats Kindahl]

Below is the list of changes that have just been committed into a local
4.0 repository of mats. When mats does a push these changes will
be propagated to the main repository and, within 24 hours after the
push, to the public repository.
For information on how to access the public repository
see http://www.mysql.com/doc/I/n/Installing_source_tree.html

ChangeSet
  1.2066 05/02/18 13:50:19 mats@stripped +2 -0
  Merge mysql.com:/home/bkroot/mysql-4.0
  into mysql.com:/home/bk/b7879-mysql-4.0

  sql/sql_yacc.yy
    1.234 05/02/18 13:50:18 mats@stripped +0 -0
    Auto merged

  sql/sql_update.cc
    1.107 05/02/18 13:50:18 mats@stripped +0 -0
    Auto merged

# This is a BitKeeper patch.  What follows are the unified diffs for the
# set of deltas contained in the patch.  The rest of the patch, the part
# that BitKeeper cares about, is below these diffs.
# User:	mats
# Host:	romeo.kindahl.net
# Root:	/home/bk/b7879-mysql-4.0/RESYNC

--- 1.106/sql/sql_update.cc	2005-01-30 11:23:54 +01:00
+++ 1.107/sql/sql_update.cc	2005-02-18 13:50:18 +01:00
@@ -473,7 +473,10 @@
       else
       {
 	DBUG_PRINT("info",("setting table `%s` for read-only", tl->alias));
-	tl->lock_type= TL_READ;
+	// If we are using the binary log, we need TL_READ_NO_INSERT to get
+	// correct order of statements. Otherwise, we use a TL_READ lock to
+	// improve performance.
+	tl->lock_type= using_update_log ? TL_READ_NO_INSERT : TL_READ;
 	tl->updating= 0;
 	wants= SELECT_ACL;
       }

--- 1.233/sql/sql_yacc.yy	2005-01-25 22:46:57 +01:00
+++ 1.234/sql/sql_yacc.yy	2005-02-18 13:50:18 +01:00
@@ -822,7 +822,7 @@
           SELECT_SYM
           {
 	    LEX *lex=Lex;
-	    lex->lock_option= (using_update_log) ? TL_READ_NO_INSERT : TL_READ;
+	    lex->lock_option= using_update_log ? TL_READ_NO_INSERT : TL_READ;
 	    if (lex->sql_command == SQLCOM_INSERT)
 	      lex->sql_command= SQLCOM_INSERT_SELECT;
 	    else if (lex->sql_command == SQLCOM_REPLACE)
@@ -1532,7 +1532,7 @@
 	{
 	  LEX *lex=Lex;
 	  lex->lock_option=TL_READ;
-	   mysql_init_select(lex);
+          mysql_init_select(lex);
 	}
 	select_options select_item_list select_into select_lock_type;