- ASSERT(transState != NULL);
+ //ASSERT(transState != NULL);
That seems a bit risky:)
> -----Original Message-----
> From: Kevin.Lewis@stripped [mailto:Kevin.Lewis@stripped]
> Sent: Wednesday, March 25, 2009 2:59 AM
> To: Jim Starkey
> Cc: Vladislav Vaintroub; 'FalconDev'
> Subject: Re: Falcon Coding Style -- The Theory
> So the style actually used is;
> 8. If the change seems a little risky, comment deletable lines
> initially. Then some time later, after the change is fully tested and
> proven, delete them.
> All the references to syncPrior are currently commented out instead of
> deleted. In a couple weeks, when the benefits of the CycleManager are
> proven, any one of us can probably take the initiative to delete them.
> Jim Starkey wrote:
> > Vladislav Vaintroub wrote:
> >> Studying recent pushes..
> >> - ASSERT(transState != NULL);
> >> + //ASSERT(transState != NULL);
> >> 8. Never delete code, comment out ;)
> > Gosh, Vlad, I do that because I make a lot of mistakes, and when
> > something blows up in my face, knowing exactly what I'd screwed up is
> > very time consuming. Part of regular edit pass to delete detritus
> > that.
> > People who make fewer mistakes than I do don't need to do things like