From: Olav Sandstaa Date: March 10 2009 8:19pm Subject: Re: Please review patch for bug#43488 List-Archive: http://lists.mysql.com/falcon/609 Message-Id: <49B6CB43.8020705@sun.com> MIME-Version: 1.0 Content-Type: text/plain; format=flowed; charset=ISO-8859-1 Content-Transfer-Encoding: 8BIT Hi Lars-Erik, The patch looks fine to me. But I do not know this part of the code so it would be good if someone who knows how this should work took a look at it too. Olav Lars-Erik Bjørk wrote: > Ladies and Gentlemen, > > Would two of you please take the time to review my patch for bug#43488 > ( http://bugs.mysql.com/bug.php?id=43488 ) available at > http://lists.mysql.com/commits/68732. Especially, I would like to get > confirmation that I release records in the catch clause in > IndexWalker::getValidatedRecord correctly (or incorrectly :) ). > > Best, > Lars-Erik >