From: Vladislav Vaintroub
Date: March 10 2009 11:24am
Subject: Re: Proposal: extension to Log interface to get error message written
 independently of falcon-debug-mask
List-Archive: http://lists.mysql.com/falcon/607
Message-Id: <49B64E08.9070201@sun.com>
MIME-Version: 1.0
Content-Type: text/plain; format=flowed; charset=ISO-8859-1
Content-Transfer-Encoding: 7BIT

Olav Sandstaa wrote:
> Hi,
> 
> I have now implement this functionality. The main added functionality to 
> the Log class is:
> 
> 1. A new debug mask called LogFatalError:
> 
> This debug mask will be on by default for the Falcon log. It will not
> be disabled if the user provides a debug mask at startup or changes the 
> debug mask for a running server.
> 
> 2. A new log method Log::fatal():
> 
> Log messages written using this method will always be written to
> Falcon/MySQL's log file.
> 
> Note that compare to my original proposal this debug mask will only be 
> on for the  original Falcon logger (StorageInterface::logger), not for 
> the "MySQL logger" (StorageInterface::mysqlLogger). Due to this the 
> default log mask is not completely maintained inside the Log class but 
> has to be set in when the Falcon logger is added to listen to the log 
> (in ha_falcon.cpp).
> 
> The patch is available here:
> 
>   http://lists.mysql.com/commits/68742
> 
> It would be great if someone could have a look at the patch and either 
> give feedback or an OK to push it.
> 
> Thanks,
> Olav

Olav, I think it is ok basically, but I'd prefer to maybe have it 
differently named. It could be situations where one wants to write to 
the log, even if there is no fatal error, but on some very interesting 
event. Maybe LogFatalError should be LogAlwaysWrite?