Chris, just out of curiosity - is it necessary to have a thread for each
single task? I might be mistaken, but do not we have a timer or similar for
that, specifically for periodic tasks?
> -----Original Message-----
> From: Christopher.Powers@stripped [mailto:Christopher.Powers@stripped]
> Sent: Thursday, January 15, 2009 2:04 AM
> To: Kevin Lewis
> Cc: FalconDev
> Subject: More on Scavenge vs DDL
>
> I decoupled updateCardinalities() from the Scavenger and moved it on to
> its own thread. Now, each scavenge simply signals it and moves on, no
> waiting on syncSysDDL.
>
> BUT...
>
> Database::scavengeRecords() commits pending system transactions, which
> of course requires a lock syncSysDDL. In the old code, this was done
> only inside of syncScavenge AND if the scavenge was not 'forced'.
>
> Load-based scavenges are the current equivalent of forced scavenges,
> and
> also should not commit pending system transactions.
>
>
> // NEW CODE
>
> void Database::scavengeRecords(void)
> {
> // Commit pending system transactions before proceeding
>
> if (systemConnection->transaction)
> commitSystemTransaction();
>
> Sync syncScavenger(&syncScavenge,
> "Database::scavengeRecords(Scavenge)");
> syncScavenger.lock(Exclusive)
> [...]
>
>
> // OLD CODE
>
> void Database::retireRecords(bool forced)
> {
> int cycle = scavengeCycle;
>
> Sync syncScavenger(&syncScavenge, "Database::retireRecords(1)");
> syncScavenger.lock(Exclusive);
>
> if (forced && scavengeCycle > cycle)
> return;
>
> // Commit pending system transactions before proceeding
>
> if (!forced && systemConnection->transaction)
> commitSystemTransaction();
>
> --
> Falcon Storage Engine Mailing List
> For list archives: http://lists.mysql.com/falcon
> To unsubscribe: http://lists.mysql.com/falcon?unsub=1
