List:Falcon Storage Engine« Previous MessageNext Message »
From:Lars-Erik Bjørk Date:January 13 2009 2:39pm
Subject:Re: Request for review
View as plain text  
On Mon, 2009-01-12 at 22:17 +0100, John H. Embretsen wrote:
> Lars-Erik Bjørk wrote:
> > Some issues on Solaris it seems, I will look into it.
> > Once again, thanks John :)
> 
> These issues seem to be resolved by doing a "make clean" before "make"
> after applying the code patch. Sorry for the false alarm...
> 

In these big-endian times, I have tested it on a Solaris Sparc as well,
without any problems. I still need a second reviewer, though.

/Lars-Erik

> Test patch looks and works very good; approve comment sent to
> commits@lists...
> 
> -- 
> John
> 
> > On Mon, 2009-01-12 at 11:23 +0100, Lars-Erik Bjørk wrote:
> >> And here is a follow-up commit that actually contains the added test
> >> files as well :)
> >>
> >> Thanks John!
> >>
> >> http://lists.mysql.com/commits/62967
> >>
> >> On Mon, 2009-01-12 at 10:38 +0100, Lars-Erik Bjørk wrote:
> >>> Please review http://lists.mysql.com/commits/62959
> >>>
> >>> /Lars-Erik
> 
> 

Thread
Request for reviewLars-Erik Bjørk12 Jan
  • Re: Request for reviewLars-Erik Bjørk12 Jan
    • Re: Request for reviewLars-Erik Bjørk12 Jan
      • Re: Request for reviewJohn H. Embretsen12 Jan
        • Re: Request for reviewLars-Erik Bjørk13 Jan
        • Re: Request for reviewLars-Erik Bjørk20 Jan