List:Falcon Storage Engine« Previous MessageNext Message »
From:Lars-Erik Bjørk Date:December 4 2008 10:30am
Subject:Re: Please review fox for bug#34479
View as plain text  
On Thu, 2008-12-04 at 09:41 +0100, Lars-Erik Bjørk wrote:
> Just to make sure that I understand things correctly :)
> 
> The trailing spaces (and minimum sort characters) I have been removing
> so far, I have converted to the given character set, so for f.eks UCS2,
> I have been looking to remove 0x0020, etc
> 
> Should it be done like this for trailing zeros as well, so that I in the
> case of ucs2 should be looking to remove 0x0000?
> 
> Also, if I try to remove only spaces (pad chars) and zeros, but not the
> minimum sort character, some queries using LIKE comparison in the Falcon
> suite starts failing.
> 

Actually there is only one test that fails:

CREATE TABLE t1 (a char(4) CHARACTER SET utf8 COLLATE utf8_turkish_ci,
KEY (a));
INSERT INTO t1 VALUES ('abc'), ('abc '), ('abcd');
SELECT count(*) FROM t1 WHERE a like 'abc%';
count(*)
-3
+1


> Kevin is correct btw, that bug#23692 has not been prioritized because it
> does not have a BETA tag.
> 
> /Lars-Erik
> 
> 
> On Wed, 2008-12-03 at 14:36 -0500, Ann W. Harrison wrote:
> > Alexander Barkov wrote:
> > 
> > > 
> > > That's true , <tab> in many collations is the smallest character
> > > (i.e. minSortChar=<tab>), and space is greater than <tab>.
> > > 
> > > So does not seem correct to remove both spaces and tabs, and
> > > then execute strnncoll() for the results in the patch for
> > > bug#34479.
> > > 
> > 
> > You're absolutely right.
> > 
> > We should not remove tabs, but only spaces.  I don't know what
> > the code does currently, but the original design (not necessarily
> > its implementation) removed only spaces.  (And, of course, trailing
> > zeros for numerics, but that's another topic.)
> > 
> > Best regards,
> > 
> > 
> > Ann
> 
> 

Thread
Please review fox for bug#34479Lars-Erik Bjørk2 Dec
  • RE: Please review fox for bug#34479Vladislav Vaintroub2 Dec
    • RE: Please review fox for bug#34479Lars-Erik Bjørk2 Dec
      • RE: Please review fox for bug#34479Lars-Erik Bjørk2 Dec
        • Re: Please review fox for bug#34479Alexander Barkov3 Dec
          • Re: Please review fox for bug#34479Lars-Erik Bjørk3 Dec
            • Re: Please review fox for bug#34479Kevin Lewis3 Dec
              • Re: Please review fox for bug#34479Ann W. Harrison3 Dec
    • Re: Please review fox for bug#34479Ann W. Harrison2 Dec
      • RE: Please review fox for bug#34479Vladislav Vaintroub2 Dec
Re: Please review fox for bug#34479Kevin Lewis3 Dec
  • Re: Please review fox for bug#34479Alexander Barkov3 Dec
    • Re: Please review fox for bug#34479Ann W. Harrison3 Dec
      • Re: Please review fox for bug#34479Lars-Erik Bjørk4 Dec
        • RE: Please review fox for bug#34479Vladislav Vaintroub4 Dec
        • Re: Please review fox for bug#34479Lars-Erik Bjørk4 Dec
          • RE: Please review fox for bug#34479Vladislav Vaintroub4 Dec
          • Re: Please review fox for bug#34479Ann W. Harrison4 Dec
        • Re: Please review fox for bug#34479Ann W. Harrison4 Dec
          • Re: Please review fox for bug#34479Lars-Erik Bjørk5 Dec
            • Re: Please review fox for bug#34479Lars-Erik Bjørk5 Dec
        • Re: Please review fox for bug#34479Alexander Barkov8 Dec
          • RE: Please review fox for bug#34479Vladislav Vaintroub8 Dec
            • Re: Please review fox for bug#34479Alexander Barkov8 Dec
            • Re: Please review fox for bug#34479Ann W. Harrison8 Dec
Re: Please review fox for bug#34479Ann W. Harrison4 Dec