From: Ann W. Harrison Date: December 3 2008 7:36pm Subject: Re: Please review fox for bug#34479 List-Archive: http://lists.mysql.com/falcon/242 Message-Id: <4936DFD9.1000709@mysql.com> MIME-Version: 1.0 Content-Type: text/plain; format=flowed; charset=UTF-8 Content-Transfer-Encoding: 7BIT Alexander Barkov wrote: > > That's true , in many collations is the smallest character > (i.e. minSortChar=), and space is greater than . > > So does not seem correct to remove both spaces and tabs, and > then execute strnncoll() for the results in the patch for > bug#34479. > You're absolutely right. We should not remove tabs, but only spaces. I don't know what the code does currently, but the original design (not necessarily its implementation) removed only spaces. (And, of course, trailing zeros for numerics, but that's another topic.) Best regards, Ann