List:Falcon Storage Engine« Previous MessageNext Message »
From:Kevin Lewis Date:November 9 2008 5:40pm
Subject:Re: incorrect threshold calculation for scavenger?
View as plain text  
Kelly,  Thanks for the heads-up.  I am working on some scavenger changes 
for Bug#34893.  I will add this change to it.

Kelly Long wrote:
> I looked further and this code is NOT used for the storage engine.  So I 
> guess it does not really impact the mysql storage engine version of 
> falcon.  We probably should change it anyway to avoid confusion.  But, I 
> guess it doesn't matter to me. :)
> 
> Kelly
> 
> Kelly Long wrote:
>> Hello Falconers,
>>
>> I noticed that this change I mentioned in May is still not in the 
>> source code base.  Should this patch be applied?
>>
>> Kelly
>>
>> -------------------------------
>>
>> Fix for incorrect calculation of record scavenger threshold and floor
>> modified:
>>   storage/falcon/Configuration.cpp
>>
>> === modified file 'storage/falcon/Configuration.cpp'
>> --- a/storage/falcon/Configuration.cpp    2008-10-22 12:01:16 +0000
>> +++ b/storage/falcon/Configuration.cpp    2008-11-07 20:00:25 +0000
>> @@ -144,8 +144,8 @@ Configuration::Configuration(const char
>>      recordMemoryMax                = getMemorySize(RECORD_MEMORY_UPPER);
>>      recordScavengeThresholdPct    = 67;
>>      recordScavengeFloorPct        = 33;
>> -    recordScavengeThreshold        = (recordMemoryMax * 100) / 
>> recordScavengeThresholdPct;
>> -    recordScavengeFloor            = (recordMemoryMax * 100) / 
>> recordScavengeFloorPct;
>> +    recordScavengeThreshold        = (recordMemoryMax * 
>> recordScavengeThresholdPct) / 100;
>> +    recordScavengeFloor            = (recordMemoryMax * 
>> recordScavengeFloorPct) / 100;
>>      serialLogWindows            = 10;    // same as SRL_MIN_WINDOWS
>>      allocationExtent            = 10;
>>      pageCacheSize                = getMemorySize(PAGE_CACHE_MEMORY);
>>
>>
>>
> 
Thread
incorrect threshold calculation for scavenger?Kelly Long9 Nov
  • Re: incorrect threshold calculation for scavenger?Kelly Long9 Nov
    • Re: incorrect threshold calculation for scavenger?Kevin Lewis9 Nov