List:Eventum General Discussion« Previous MessageNext Message »
From:M  IN BLR SISL Srivathsan Date:June 15 2009 4:12am
Subject:RE: Bug in Mandatory Custom fields
View as plain text  
Hi,

The Bug persists in Issue Closure page also.  If I have a Custom Field that is "Required"
and available only in Closure Form, I could still go ahead and close the Issue without
providing any value.

Not just the Custom field, I could close the Issue without selecting the "Status"
drop-down too.  This I noticed in Eventum 2.2

Once again, I earnest request a quick-fix / patch for this.

Thanks and rgds,
Watson

-----Original Message-----
From: Srivathsan, M IN BLR SISL [mailto:M.Srivathsan@stripped]
Sent: Thu, 04-Jun-2009 10:29
To: Barry-Home
Cc: Eventum
Subject: RE: Bug in Mandatory Custom fields

Hi Barry,

Please don't bother.  A little bit of googling helped me in learning the Patch & Diff
fundas.  And your patch Works!!

Once again, my sincere thanks for that.  Hopefully, this is also assimilated into the next
release of Eventum.

Thanks and rgds,
Watson

-----Original Message-----
From: Srivathsan, M IN BLR SISL [mailto:M.Srivathsan@stripped]
Sent: Thu, 04-Jun-2009 08:17
To: Barry-Home
Cc: Eventum
Subject: RE: Bug in Mandatory Custom fields

Hi Barry,

Many thanks for the patch.  But please pardon me for asking this - how do I apply this
patch?  I know there is something called a patch utility but please walk me through the
baby steps.  Even if you could point out to some quick guide also would do.

Thanks and rgds,
Watson

________________________________
From: Barry-Home [mailto:rumpole6@stripped]
Sent: Thu, 04-Jun-2009 01:12
To: Srivathsan, M IN BLR SISL
Cc: Eventum
Subject: Re: Bug in Mandatory Custom fields

Following Patches solve the problem:

--- current/eventum-2.2/templates/edit_custom_fields.tpl.html    2009-06-03
15:27:38.000000000 -0400
+++ eventum-2.2/templates/edit_custom_fields.tpl.html    2008-11-06 11:58:37.000000000
-0500
@@ -56,7 +56,7 @@
         {/if}
       class="default" name="custom_fields[{$custom_fields[i].fld_id}]{if
$custom_fields[i].fld_type == 'multiple'}[]{/if}" tabindex="{$tabindex++}">

-      {if $custom_fields[i].fld_type != 'multiple'}<option value="-1">{t}Please
choose an option{/t}</option>{/if}
+      {if $custom_fields[i].fld_type != 'multiple'}<option value="">{t}Please
choose an option{/t}</option>{/if}
       {html_options options=$custom_fields[i].field_options
selected=$smarty.request.custom_fields[$fld_id]|default:$custom_fields[i].selected_cfo_id|default:$custom_fields[i].default_value}
     </select>
     {/if}

********************
****************

--- current/eventum-2.2/js/validation.js    2009-06-03 15:29:23.000000000 -0400
+++ eventum-2.2/js/validation.js    2008-07-28 16:05:00.000000000 -0400
@@ -260,24 +260,23 @@
     for (var i = 0; i < custom_fields_info.length; i++) {
         var info = custom_fields_info[i];
         var field = $('#custom_field_' + info.id);
+
         if (((field.val().length < 1) || (field.val() == -1)) &&
(field.parent().parent().css('display') == 'none')) {
             continue;
         }
-        if (info.required == 1) {
-            if (info.type == 'combo') {
-          if (getSelectedOption(f, field.attr('name')) == '-1') {
-        errors[errors.length] = new Option(info.title, field.attr('name'));
-
-

+        if (info.required == 1) {
+            if (info.type == 'combo') {
+                if (getSelectedOption(f, field.attr('name')) == '-1') {
+                    errors[errors.length] = new Option(info.title, field...val());
                 }
             } else if (info.type == 'multiple') {
                 if (!hasOneSelected(f, field.attr('name'))) {
-                    errors[errors.length] = new Option(info.title, field...attr('name'));
+                    errors[errors.length] = new Option(info.title, field...val());
                 }
             } else {
                 if (isWhitespace(field.val())) {
-                    errors[errors.length] = new Option(info.title, field...attr('name'));
+                    errors[errors.length] = new Option(info.title, field...val());
                 }
             }
         }
@@ -350,9 +349,7 @@
 function getSelectedOption(f, field_name)
 {
     for (var i = 0; i < f.elements.length; i++) {
-
         if (f.elements[i].name == field_name) {
-
             if (f.elements[i].options.length > 0) {
                 if (f.elements[i].selectedIndex == -1) {
                     return -1;



Srivathsan, M IN BLR SISL wrote:

Hi,



After digging to some extent, I found that the JavaScript function checkCustomFields()
defined in <eventum>/js/validation.js is quite different from that in v2.1.1.  The
mandatory check for Custom Fields works in 2.1.1.



Since I am not a PHP / JavaScript / Smarty maven, could someone help me out please?



Thanks and rgds,

Watson



-----Original Message-----

From: Srivathsan, M IN BLR SISL [mailto:M.Srivathsan@stripped]

Sent: Sat, 30-May-2009 10:35

To: Eventum

Subject: Bug in Mandatory Custom fields



Hi,



Has any one of you encountered this problem?  I created a few custom fields (drop-downs
with pre-defined values set through the tool itself) and also flagged them as "Required"
during creation.  Now in my Create Issue form, even if I don't select a value in those
custom fields, I am still able to submit the new issue.  I very much see the "mandatory"
indicator '*' against the field names.  I feel that this is a bug.



Just wanted to check if there is a patch or solution already available or is it that I got
something wrong.



Thanks and rgds,

Watson



________________________________

Important notice: This e-mail and any attachment there to contains corporate proprietary
information. If you have received it by mistake, please notify us immediately by reply
e-mail and delete this e-mail and its attachments from your system.

Thank You.



Important notice: This e-mail and any attachment there to contains corporate proprietary
information. If you have received it by mistake, please notify us immediately by reply
e-mail and delete this e-mail and its attachments from your system.

Thank You.










________________________________








No virus found in this incoming message.

Checked by AVG - www.avg.com<http://www.avg.com>

Version: 8.5.339 / Virus Database: 270.12.52/2152 - Release Date: 06/03/09 05:53:00






________________________________
Important notice: This e-mail and any attachment there to contains corporate proprietary
information. If you have received it by mistake, please notify us immediately by reply
e-mail and delete this e-mail and its attachments from your system.
Thank You.

Important notice: This e-mail and any attachment there to contains corporate proprietary
information. If you have received it by mistake, please notify us immediately by reply
e-mail and delete this e-mail and its attachments from your system.
Thank You.

--
Eventum Users Mailing List
For list archives: http://lists.mysql.com/eventum-users
To unsubscribe:    http://lists.mysql.com/eventum-users?unsub=1


Important notice: This e-mail and any attachment there to contains corporate proprietary
information. If you have received it by mistake, please notify us immediately by reply
e-mail and delete this e-mail and its attachments from your system.
Thank You.
Thread
Bug in Mandatory Custom fieldsM  IN BLR SISL Srivathsan30 May
  • RE: Bug in Mandatory Custom fieldsM  IN BLR SISL Srivathsan3 Jun
    • Re: Bug in Mandatory Custom fieldsBarry-Home3 Jun
      • RE: Bug in Mandatory Custom fieldsM  IN BLR SISL Srivathsan4 Jun
        • RE: Bug in Mandatory Custom fieldsM  IN BLR SISL Srivathsan4 Jun
          • RE: Bug in Mandatory Custom fieldsM  IN BLR SISL Srivathsan15 Jun
            • RE: Bug in Mandatory Custom fieldsM  IN BLR SISL Srivathsan18 Jun