List:Commits« Previous MessageNext Message »
From:Dao-Gang.Qu Date:February 11 2010 12:07pm
Subject:bzr commit into mysql-5.5-trunk-bugfixing branch (Dao-Gang.Qu:2940) Bug#43913
View as plain text  
#At file:///home/daogangqu/mysql/bzrwork/bug43913/mysql-trunk-bugfixing/ based on revid:luis.soares@stripped

 2940 Dao-Gang.Qu@stripped	2010-02-11
      Bug #43913  rpl_cross_version can't pass on conflicts complainig clash with
      --slave-load-tm
            
      The MDL_SHARED lock was introduced for an object in 5.4, but the 'TABLE_LIST' 
      object was not initialized with the MDL_SHARED lock when applying event with 
      LOAD DATA INFILE into table. So the failure is caused when checking the 
      MDL_SHARED lock for the object.
      To fix the problem, the 'TABLE_LIST' object was initialized with the MDL_SHARED 
      lock when applying event with LOAD DATA INFILE into table.
     @ mysql-test/suite/rpl/t/disabled.def
        Got rid of the line for enabling 'rpl_cross_version' test.

    modified:
      mysql-test/suite/rpl/t/disabled.def
      mysql-test/suite/rpl/t/rpl_cross_version-master.opt
      sql/log_event.cc
=== modified file 'mysql-test/suite/rpl/t/disabled.def'
--- a/mysql-test/suite/rpl/t/disabled.def	2009-12-11 09:39:38 +0000
+++ b/mysql-test/suite/rpl/t/disabled.def	2010-02-11 12:07:37 +0000
@@ -12,5 +12,4 @@
 
 rpl_get_master_version_and_clock:  # Bug#46931 2009-10-17 joro rpl.rpl_get_master_version_and_clock fails
 rpl_row_create_table            : Bug#45576 2009-12-01 joro rpl_row_create_table fails on PB2
-rpl_cross_version               : BUG#43913 2009-10-22 luis rpl_cross_version fails with symptom in described in bug report
 rpl_spec_variables		: BUG#47661 2009-10-27 jasonh rpl_spec_variables fails on PB2 hpux

=== modified file 'mysql-test/suite/rpl/t/rpl_cross_version-master.opt'
--- a/mysql-test/suite/rpl/t/rpl_cross_version-master.opt	2009-01-27 11:33:30 +0000
+++ b/mysql-test/suite/rpl/t/rpl_cross_version-master.opt	2010-02-11 12:07:37 +0000
@@ -1 +1 @@
---replicate-same-server-id --relay-log=slave-relay-bin --secure-file-priv=$MYSQL_TMP_DIR
+--replicate-same-server-id --relay-log=slave-relay-bin

=== modified file 'sql/log_event.cc'
--- a/sql/log_event.cc	2010-01-30 19:13:36 +0000
+++ b/sql/log_event.cc	2010-02-11 12:07:37 +0000
@@ -4634,10 +4634,7 @@ int Load_log_event::do_apply_event(NET* 
     thd->warning_info->opt_clear_warning_info(thd->query_id);
 
     TABLE_LIST tables;
-    bzero((char*) &tables,sizeof(tables));
-    tables.db= thd->strmake(thd->db, thd->db_length);
-    tables.alias = tables.table_name = (char*) table_name;
-    tables.lock_type = TL_WRITE;
+    tables.init_one_table(thd->db, table_name, TL_WRITE);
     tables.updating= 1;
 
     // the table will be opened in mysql_load    


Attachment: [text/bzr-bundle] bzr/dao-gang.qu@sun.com-20100211120737-m2qfs0yl9f3uyj06.bundle
Thread
bzr commit into mysql-5.5-trunk-bugfixing branch (Dao-Gang.Qu:2940) Bug#43913Dao-Gang.Qu11 Feb