List:Commits« Previous MessageNext Message »
From:jonas Date:August 2 2006 12:45pm
Subject:bk commit into 5.1 tree (jonas:1.2259)
View as plain text  
Below is the list of changes that have just been committed into a local
5.1 repository of jonas. When jonas does a push these changes will
be propagated to the main repository and, within 24 hours after the
push, to the public repository.
For information on how to access the public repository
see http://dev.mysql.com/doc/mysql/en/installing-source-tree.html

ChangeSet@stripped, 2006-08-02 14:45:29+02:00, jonas@stripped +4 -0
  ndb -
    make Dblqh use OM_AUTO_SYNC

  storage/ndb/include/kernel/signaldata/FsOpenReq.hpp@stripped, 2006-08-02 14:45:27+02:00, jonas@stripped +1 -0
    make Dblqh us OM_AUTO_SYNC

  storage/ndb/src/kernel/blocks/dblqh/Dblqh.hpp@stripped, 2006-08-02 14:45:27+02:00, jonas@stripped +1 -5
    make Dblqh us OM_AUTO_SYNC

  storage/ndb/src/kernel/blocks/dblqh/DblqhMain.cpp@stripped, 2006-08-02 14:45:27+02:00, jonas@stripped +12 -14
    make Dblqh us OM_AUTO_SYNC

  storage/ndb/src/kernel/vm/pc.hpp@stripped, 2006-08-02 14:45:27+02:00, jonas@stripped +0 -7
    remove unused #defines

# This is a BitKeeper patch.  What follows are the unified diffs for the
# set of deltas contained in the patch.  The rest of the patch, the part
# that BitKeeper cares about, is below these diffs.
# User:	jonas
# Host:	perch.ndb.mysql.com
# Root:	/home/jonas/src/51-work

--- 1.5/storage/ndb/include/kernel/signaldata/FsOpenReq.hpp	2006-08-02 14:45:33 +02:00
+++ 1.6/storage/ndb/include/kernel/signaldata/FsOpenReq.hpp	2006-08-02 14:45:33 +02:00
@@ -43,6 +43,7 @@
   friend class Lgman;
   friend class Tsman;
   friend class Restore;
+  friend class Dblqh;
 
   /**
    * For printing

--- 1.52/storage/ndb/src/kernel/blocks/dblqh/Dblqh.hpp	2006-08-02 14:45:33 +02:00
+++ 1.53/storage/ndb/src/kernel/blocks/dblqh/Dblqh.hpp	2006-08-02 14:45:33 +02:00
@@ -29,6 +29,7 @@
 #include <signaldata/LCP.hpp>
 #include <signaldata/LqhTransConf.hpp>
 #include <signaldata/LqhFrag.hpp>
+#include <signaldata/FsOpenReq.hpp>
 
 // primary key is stored in TUP
 #include "../dbtup/Dbtup.hpp"
@@ -1514,11 +1515,6 @@
     UintR lastWordWritten;
     /**
      *       This variable contains the last word written in the last page.
-     */
-    UintR logFilePagesToDiskWithoutSynch;
-    /**
-     *       This variable keeps track of the number of pages written since
-     *       last synch on this log file.
      */
     LogFileStatus logFileStatus;
     /**

--- 1.117/storage/ndb/src/kernel/blocks/dblqh/DblqhMain.cpp	2006-08-02 14:45:33 +02:00
+++ 1.118/storage/ndb/src/kernel/blocks/dblqh/DblqhMain.cpp	2006-08-02 14:45:33 +02:00
@@ -12415,7 +12415,6 @@
   ptrCheckGuard(logPartPtr, clogPartFileSize, logPartRecord);
   logFilePtr.p->currentMbyte = 0;
   logFilePtr.p->filePosition = 0;
-  logFilePtr.p->logFilePagesToDiskWithoutSynch = 0;
 }//Dblqh::initFsopenconf()
 
 /* ========================================================================= */
@@ -13062,14 +13061,16 @@
 /* ------------------------------------------------------------------------- */
 void Dblqh::openFileRw(Signal* signal, LogFileRecordPtr olfLogFilePtr) 
 {
+  FsOpenReq* req = (FsOpenReq*)signal->getDataPtrSend();
   signal->theData[0] = cownref;
   signal->theData[1] = olfLogFilePtr.i;
   signal->theData[2] = olfLogFilePtr.p->fileName[0];
   signal->theData[3] = olfLogFilePtr.p->fileName[1];
   signal->theData[4] = olfLogFilePtr.p->fileName[2];
   signal->theData[5] = olfLogFilePtr.p->fileName[3];
-  signal->theData[6] = ZOPEN_READ_WRITE;
-  sendSignal(NDBFS_REF, GSN_FSOPENREQ, signal, 7, JBA);
+  signal->theData[6] = ZOPEN_READ_WRITE | FsOpenReq::OM_AUTOSYNC;
+  req->auto_sync_size = MAX_REDO_PAGES_WITHOUT_SYNCH * sizeof(LogPageRecord);
+  sendSignal(NDBFS_REF, GSN_FSOPENREQ, signal, FsOpenReq::SignalLength, JBA);
 }//Dblqh::openFileRw()
 
 /* ------------------------------------------------------------------------- */
@@ -13080,14 +13081,16 @@
 void Dblqh::openLogfileInit(Signal* signal) 
 {
   logFilePtr.p->logFileStatus = LogFileRecord::OPENING_INIT;
+  FsOpenReq* req = (FsOpenReq*)signal->getDataPtrSend();
   signal->theData[0] = cownref;
   signal->theData[1] = logFilePtr.i;
   signal->theData[2] = logFilePtr.p->fileName[0];
   signal->theData[3] = logFilePtr.p->fileName[1];
   signal->theData[4] = logFilePtr.p->fileName[2];
   signal->theData[5] = logFilePtr.p->fileName[3];
-  signal->theData[6] = 0x302;
-  sendSignal(NDBFS_REF, GSN_FSOPENREQ, signal, 7, JBA);
+  signal->theData[6] = 0x302 | FsOpenReq::OM_AUTOSYNC;
+  req->auto_sync_size = MAX_REDO_PAGES_WITHOUT_SYNCH * sizeof(LogPageRecord);
+  sendSignal(NDBFS_REF, GSN_FSOPENREQ, signal, FsOpenReq::SignalLength, JBA);
 }//Dblqh::openLogfileInit()
 
 /* OPEN FOR READ/WRITE, DO CREATE AND DO TRUNCATE FILE */
@@ -13114,14 +13117,16 @@
       return;
     }//if
     onlLogFilePtr.p->logFileStatus = LogFileRecord::OPENING_WRITE_LOG;
+    FsOpenReq* req = (FsOpenReq*)signal->getDataPtrSend();
     signal->theData[0] = cownref;
     signal->theData[1] = onlLogFilePtr.i;
     signal->theData[2] = onlLogFilePtr.p->fileName[0];
     signal->theData[3] = onlLogFilePtr.p->fileName[1];
     signal->theData[4] = onlLogFilePtr.p->fileName[2];
     signal->theData[5] = onlLogFilePtr.p->fileName[3];
-    signal->theData[6] = 2;
-    sendSignal(NDBFS_REF, GSN_FSOPENREQ, signal, 7, JBA);
+    signal->theData[6] = 2 | FsOpenReq::OM_AUTOSYNC;
+    req->auto_sync_size = MAX_REDO_PAGES_WITHOUT_SYNCH * sizeof(LogPageRecord);
+    sendSignal(NDBFS_REF, GSN_FSOPENREQ, signal, FsOpenReq::SignalLength, JBA);
   }//if
 }//Dblqh::openNextLogfile()
 
@@ -16138,15 +16143,8 @@
   signal->theData[0] = logFilePtr.p->fileRef;
   signal->theData[1] = cownref;
   signal->theData[2] = lfoPtr.i;
-  logFilePtr.p->logFilePagesToDiskWithoutSynch += twlpNoPages;
   if (twlpType == ZLAST_WRITE_IN_FILE) {
     jam();
-    logFilePtr.p->logFilePagesToDiskWithoutSynch = 0;
-    signal->theData[3] = ZLIST_OF_MEM_PAGES_SYNCH;
-  } else if (logFilePtr.p->logFilePagesToDiskWithoutSynch >
-             MAX_REDO_PAGES_WITHOUT_SYNCH) {
-    jam();
-    logFilePtr.p->logFilePagesToDiskWithoutSynch = 0;
     signal->theData[3] = ZLIST_OF_MEM_PAGES_SYNCH;
   } else {
     jam();

--- 1.13/storage/ndb/src/kernel/vm/pc.hpp	2006-08-02 14:45:33 +02:00
+++ 1.14/storage/ndb/src/kernel/vm/pc.hpp	2006-08-02 14:45:33 +02:00
@@ -163,17 +163,10 @@
 #define NO_OF_FRAGS_PER_CHUNK 4
 #define LOG_NO_OF_FRAGS_PER_CHUNK 2
 
-/**
-* Page Header Size for pages
-*/
-#define ZPAGE_HEADER_SIZE 32
-#define ZPAGE_FRAG_PAGE_ID_POS 4 /* POSITION OF FRAG PAGE ID WHEN USED*/
-
 /* ---------------------------------------------------------------- */
 // To avoid synching too big chunks at a time we synch after writing
 // a certain number of data/UNDO pages. (e.g. 2 MBytes).
 /* ---------------------------------------------------------------- */
-#define MAX_PAGES_WITHOUT_SYNCH 64
 #define MAX_REDO_PAGES_WITHOUT_SYNCH 32
 
 /* ------------------------------------------------------------------ */
Thread
bk commit into 5.1 tree (jonas:1.2259)jonas2 Aug