List:Commits« Previous MessageNext Message »
From:Konstantin Osipov Date:January 25 2010 9:09pm
Subject:bzr commit into mysql-5.6-next-mr branch (kostja:3060) Bug#46272
View as plain text  
#At file:///opt/local/work/next-4284-stage/ based on revid:dlenev@stripped

 3060 Konstantin Osipov	2010-01-26
      Bug#46272, code review, update a comment.

    modified:
      sql/mdl.cc
=== modified file 'sql/mdl.cc'
--- a/sql/mdl.cc	2010-01-25 20:28:44 +0000
+++ b/sql/mdl.cc	2010-01-25 21:08:59 +0000
@@ -1150,7 +1150,7 @@ MDL_context::acquire_lock(MDL_request *m
   if (! (ticket= MDL_ticket::create(this, mdl_request->type)))
     return TRUE;
 
-  /* The below call also implicitly locks MDL_lock::m_mutex. */
+  /* The below call implicitly locks MDL_lock::m_mutex on success. */
   if (! (lock= mdl_locks.find_or_insert(key)))
   {
     MDL_ticket::destroy(ticket);
@@ -1273,7 +1273,7 @@ MDL_context::try_acquire_lock_impl(MDL_r
   if (!(ticket= MDL_ticket::create(this, mdl_request->type)))
     return TRUE;
 
-  /* The below call also implicitly locks MDL_lock::m_mutex. */
+  /* The below call implicitly locks MDL_lock::m_mutex on success. */
   if (!(lock= mdl_locks.find_or_insert(key)))
   {
     MDL_ticket::destroy(ticket);
@@ -1458,7 +1458,7 @@ bool MDL_context::acquire_exclusive_lock
   if (!(ticket= MDL_ticket::create(this, mdl_request->type)))
     return TRUE;
 
-  /* The below call also implicitly locks MDL_lock::m_mutex. */
+  /* The below call implicitly locks MDL_lock::m_mutex on success. */
   if (!(lock= mdl_locks.find_or_insert(key)))
   {
     MDL_ticket::destroy(ticket);
@@ -1933,7 +1933,7 @@ MDL_context::wait_for_lock(MDL_request *
 
     MDL_key *key= &mdl_request->key;
 
-    /* The below call also implicitly locks MDL_lock::m_mutex. */
+    /* The below call implicitly locks MDL_lock::m_mutex on success. */
     if (! (lock= mdl_locks.find(key)))
       return FALSE;
 


Attachment: [text/bzr-bundle] bzr/kostja@sun.com-20100125210859-hbna0427vocljymk.bundle
Thread
bzr commit into mysql-5.6-next-mr branch (kostja:3060) Bug#46272Konstantin Osipov25 Jan