List:Commits« Previous MessageNext Message »
From:Sergey Vojtovich Date:January 22 2010 9:56am
Subject:bzr commit into mysql-5.1-bugteam branch (svoj:3331)
View as plain text  
#At file:///home/svoj/devel/innodb-snapshots/mysql-5.1-bugteam/ based on revid:svoj@stripped

 3331 Sergey Vojtovich	2010-01-22
      Applying InnoDB snapshot 
      
      Detailed revision comments:
      
      r6422 | marko | 2010-01-12 11:34:27 +0200 (Tue, 12 Jan 2010) | 3 lines
      branches/5.1: Non-functional change:
      Make innobase_get_int_col_max_value() a static function.
      It does not access any fields of class ha_innobase.

    modified:
      storage/innobase/handler/ha_innodb.cc
      storage/innobase/handler/ha_innodb.h
=== modified file 'storage/innobase/handler/ha_innodb.cc'
--- a/storage/innobase/handler/ha_innodb.cc	2010-01-13 10:28:42 +0000
+++ b/storage/innobase/handler/ha_innodb.cc	2010-01-22 09:56:32 +0000
@@ -3652,11 +3652,12 @@ skip_field:
 
 /************************************************************************
 Get the upper limit of the MySQL integral and floating-point type. */
-
+static
 ulonglong
-ha_innobase::innobase_get_int_col_max_value(
-/*========================================*/
-	const Field*	field)
+innobase_get_int_col_max_value(
+/*===========================*/
+				/* out: maximum allowed value for the field */
+	const Field*	field)	/* in: MySQL field */
 {
 	ulonglong	max_value = 0;
 

=== modified file 'storage/innobase/handler/ha_innodb.h'
--- a/storage/innobase/handler/ha_innodb.h	2009-09-24 14:52:52 +0000
+++ b/storage/innobase/handler/ha_innodb.h	2010-01-22 09:56:32 +0000
@@ -80,7 +80,6 @@ class ha_innobase: public handler
 	ulong innobase_update_autoinc(ulonglong	auto_inc);
 	ulong innobase_initialize_autoinc();
 	dict_index_t* innobase_get_index(uint keynr);
- 	ulonglong innobase_get_int_col_max_value(const Field* field);
 
 	/* Init values for the class: */
  public:


Attachment: [text/bzr-bundle] bzr/svoj@sun.com-20100122095632-j8ssd5csnlzp1zpf.bundle
Thread
bzr commit into mysql-5.1-bugteam branch (svoj:3331)Sergey Vojtovich22 Jan