bzr commit into mysql-5.1-mtr branch (Bjorn.Munch:2876) Bug#49269

[Bjorn Munch]

#At file:///home/bm136801/my/unreap-51/ based on revid:bjorn.munch@stripped

 2876 Bjorn Munch	2010-01-07
      Bug #49269 mysqltest crashes on 'reap' if query executed after 'send'
      Undid amendment allowing pending reap after switching connections
      Moved check for pending reap earlier; failed if running with ps-protocol

    modified:
      client/mysqltest.cc
      mysql-test/r/mysqltest.result
      mysql-test/suite/sys_vars/t/innodb_table_locks_func.test
      mysql-test/suite/sys_vars/t/sql_low_priority_updates_func.test
      mysql-test/t/mysqltest.test
      mysql-test/t/partition_innodb_semi_consistent.test
=== modified file 'client/mysqltest.cc'
--- a/client/mysqltest.cc	2010-01-06 11:56:22 +0000
+++ b/client/mysqltest.cc	2010-01-07 10:22:45 +0000
@@ -4622,7 +4622,6 @@ void select_connection_name(const char *
   if (!con)
     die("connection '%s' not found in connection pool", name);
 
-  con->pending= FALSE;
   set_current_connection(con);
 
   DBUG_VOID_RETURN;
@@ -6517,9 +6516,6 @@ void run_query_normal(struct st_connecti
 
   if (flags & QUERY_SEND_FLAG)
   {
-    if (cn->pending)
-      die ("Cannot run query on connection between send and reap");
-    
     /*
       Send the query
     */
@@ -7111,6 +7107,9 @@ void run_query(struct st_connection *cn,
 
   init_dynamic_string(&ds_warnings, NULL, 0, 256);
 
+  if (cn->pending && (flags & QUERY_SEND_FLAG))
+    die ("Cannot run query on connection between send and reap");
+
   /*
     Evaluate query if this is an eval command
   */

=== modified file 'mysql-test/r/mysqltest.result'
--- a/mysql-test/r/mysqltest.result	2010-01-06 11:56:22 +0000
+++ b/mysql-test/r/mysqltest.result	2010-01-07 10:22:45 +0000
@@ -542,13 +542,6 @@ f1
 Abcd
 mysqltest: At line 2: Cannot run query on connection between send and reap
 select * from t1;;
-select * from t1;;
-select 1;
-1
-1
-select 2;
-2
-2
 drop table t1;
 mysqltest: At line 1: Missing required argument 'filename' to command 'remove_file'
 mysqltest: At line 1: Missing required argument 'filename' to command 'write_file'

=== modified file 'mysql-test/suite/sys_vars/t/innodb_table_locks_func.test'
--- a/mysql-test/suite/sys_vars/t/innodb_table_locks_func.test	2009-01-29 16:59:46 +0000
+++ b/mysql-test/suite/sys_vars/t/innodb_table_locks_func.test	2010-01-07 10:22:45 +0000
@@ -78,6 +78,7 @@ COMMIT;
 
 --echo 'CONNECTION con2'
 CONNECTION con2;
+reap;
 UNLOCK tables;
 
 DROP TABLE t1;

=== modified file 'mysql-test/suite/sys_vars/t/sql_low_priority_updates_func.test'
--- a/mysql-test/suite/sys_vars/t/sql_low_priority_updates_func.test	2009-03-20 17:11:22 +0000
+++ b/mysql-test/suite/sys_vars/t/sql_low_priority_updates_func.test	2010-01-07 10:22:45 +0000
@@ -127,6 +127,7 @@ connection con0;
 SET SESSION low_priority_updates = OFF;
 --echo ** Connection con1 **
 connection con1;
+reap;
 SET SESSION low_priority_updates = OFF;
 --echo ** Connection default**
 connection default;

=== modified file 'mysql-test/t/mysqltest.test'
--- a/mysql-test/t/mysqltest.test	2010-01-06 11:56:22 +0000
+++ b/mysql-test/t/mysqltest.test	2010-01-07 10:22:45 +0000
@@ -1654,18 +1654,6 @@ EOF
 --exec $MYSQL_TEST < $MYSQLTEST_VARDIR/tmp/mysqltest.in 2>&1
 remove_file $MYSQLTEST_VARDIR/tmp/mysqltest.in;
 
-# 7. Test that stmt after send without reap IS allowed 
-#    if we have switched connections
-
-connect (test_con1,localhost,root,,);
---send select * from t1;
-connection default;
-select 1;
-connection test_con1;
-select 2;
-disconnect test_con1;
-connection default;
-
 drop table t1;
 
 # ----------------------------------------------------------------------------

=== modified file 'mysql-test/t/partition_innodb_semi_consistent.test'
--- a/mysql-test/t/partition_innodb_semi_consistent.test	2009-01-13 22:12:16 +0000
+++ b/mysql-test/t/partition_innodb_semi_consistent.test	2010-01-07 10:22:45 +0000
@@ -187,6 +187,7 @@ SELECT * FROM t1;
 
 --echo # Switch to connection con2
 connection con2;
+reap;
 SELECT * FROM t1;
 
 connection default;


Attachment: [text/bzr-bundle] bzr/[e-mail]