He Zhenxing wrote:
> Hi,
>
> Approved, only one comment, why increase master-retry-count to 240. I
> think 60 is long enough.
>
Yes. It's not necessary to increase master-retry-count.
Best Regards,
Daogang
> Dao-Gang.Qu@stripped wrote:
>
>> #At file:///home/daogangqu/mysql/bzrwork/bug49191/mysql-5.1-bugteam/ based on
> revid:luis.soares@stripped
>>
>> 3296 Dao-Gang.Qu@stripped 2009-12-24
>> Bug #49191 rpl_get_master_version_and_clock failed on PB2:
> COM_REGISTER_SLAVE failed
>>
>> The 'rpl_get_master_version_and_clock' test verifies if the slave I/O
>> thread tries to reconnect to master when it tries to get the values of
>> the UNIX_TIMESTAMP, SERVER_ID from master under network disconnection.
>> So the master server is restarted for making the transient network
>> disconnection, during the period the COM_REGISTER_SLAVE failures are
>> produced in server log file when the slave I/O thread tries to
>> register on master.
>>
>> To fix the problem, suppress COM_REGISTER_SLAVE failures in server log
>> file by mtr suppression, because they are expected.
>> @ mysql-test/suite/rpl/t/rpl_get_master_version_and_clock-slave.opt
>> Increase the master retry count, so that the slave I/O thread
>> has enough time to reconnect master successfully.
>>
>> modified:
>> mysql-test/suite/rpl/r/rpl_get_master_version_and_clock.result
>> mysql-test/suite/rpl/t/rpl_get_master_version_and_clock-slave.opt
>> mysql-test/suite/rpl/t/rpl_get_master_version_and_clock.test
>> === modified file
> 'mysql-test/suite/rpl/r/rpl_get_master_version_and_clock.result'
>> --- a/mysql-test/suite/rpl/r/rpl_get_master_version_and_clock.result 2009-10-29
> 02:26:59 +0000
>> +++ b/mysql-test/suite/rpl/r/rpl_get_master_version_and_clock.result 2009-12-24
> 07:29:51 +0000
>> @@ -4,10 +4,9 @@ reset master;
>> reset slave;
>> drop table if exists t1,t2,t3,t4,t5,t6,t7,t8,t9;
>> start slave;
>> -call mtr.add_suppression("Get master clock failed with error: ");
>> -call mtr.add_suppression("Get master SERVER_ID failed with error: ");
>> -call mtr.add_suppression("Slave I/O: Master command COM_REGISTER_SLAVE failed:
> failed registering on master, reconnecting to try again");
>> +call mtr.add_suppression("Slave I/O: Master command COM_REGISTER_SLAVE failed:
> .*");
>> call mtr.add_suppression("Fatal error: The slave I/O thread stops because master
> and slave have equal MySQL server ids; .*");
>> +call mtr.add_suppression("Slave I/O thread .* register on master");
>> SELECT IS_FREE_LOCK("debug_lock.before_get_UNIX_TIMESTAMP");
>> IS_FREE_LOCK("debug_lock.before_get_UNIX_TIMESTAMP")
>> 1
>>
>> === modified file
> 'mysql-test/suite/rpl/t/rpl_get_master_version_and_clock-slave.opt'
>> ---
> a/mysql-test/suite/rpl/t/rpl_get_master_version_and_clock-slave.opt 2009-10-29 02:26:59
> +0000
>> +++
> b/mysql-test/suite/rpl/t/rpl_get_master_version_and_clock-slave.opt 2009-12-24 07:29:51
> +0000
>> @@ -1 +1 @@
>> ---master-retry-count=60
>> +--master-retry-count=240
>>
>> === modified file 'mysql-test/suite/rpl/t/rpl_get_master_version_and_clock.test'
>> --- a/mysql-test/suite/rpl/t/rpl_get_master_version_and_clock.test 2009-10-29
> 02:26:59 +0000
>> +++ b/mysql-test/suite/rpl/t/rpl_get_master_version_and_clock.test 2009-12-24
> 07:29:51 +0000
>> @@ -16,12 +16,13 @@
>>
>> source include/master-slave.inc;
>> source include/have_debug.inc;
>> -call mtr.add_suppression("Get master clock failed with error: ");
>> -call mtr.add_suppression("Get master SERVER_ID failed with error: ");
>> -call mtr.add_suppression("Slave I/O: Master command COM_REGISTER_SLAVE failed:
> failed registering on master, reconnecting to try again");
>> +
>> +connection slave;
>> +call mtr.add_suppression("Slave I/O: Master command COM_REGISTER_SLAVE failed:
> .*");
>> call mtr.add_suppression("Fatal error: The slave I/O thread stops because master
> and slave have equal MySQL server ids; .*");
>> +call mtr.add_suppression("Slave I/O thread .* register on master");
>> +
>> #Test case 1: Try to get the value of the UNIX_TIMESTAMP from master under
> network disconnection
>> -connection slave;
>> let $debug_saved= `select @@global.debug`;
>>
>> let $debug_lock= "debug_lock.before_get_UNIX_TIMESTAMP";
>>
>>
>
>
>
>
