List:Commits« Previous MessageNext Message »
From:jonas Date:January 12 2006 9:48am
Subject:bk commit into 5.1 tree (jonas:1.2043)
View as plain text  
Below is the list of changes that have just been committed into a local
5.1 repository of jonas. When jonas does a push these changes will
be propagated to the main repository and, within 24 hours after the
push, to the public repository.
For information on how to access the public repository
see http://dev.mysql.com/doc/mysql/en/installing-source-tree.html

ChangeSet
  1.2043 06/01/12 10:48:36 jonas@stripped +1 -0
  ndb -
    fix Suma get buffer ptr, adopt to new page pool in tup

  storage/ndb/src/kernel/blocks/suma/Suma.cpp
    1.30 06/01/12 10:48:33 jonas@stripped +8 -2
    Fix new page pool usage
      previously it accepted page = base + RNIL, since it didnt use page anyway, sort of a prefetch...

# This is a BitKeeper patch.  What follows are the unified diffs for the
# set of deltas contained in the patch.  The rest of the patch, the part
# that BitKeeper cares about, is below these diffs.
# User:	jonas
# Host:	perch.ndb.mysql.com
# Root:	/home/jonas/src/51-new

--- 1.29/storage/ndb/src/kernel/blocks/suma/Suma.cpp	2006-01-11 09:26:03 +01:00
+++ 1.30/storage/ndb/src/kernel/blocks/suma/Suma.cpp	2006-01-12 10:48:33 +01:00
@@ -4093,8 +4093,14 @@
   Bucket* bucket= c_buckets+buck;
   Page_pos pos= bucket->m_buffer_head;
 
-  Buffer_page* page= (Buffer_page*)m_tup->c_page_pool.getPtr(pos.m_page_id);
-  Uint32* ptr= page->m_data + pos.m_page_pos;
+  Buffer_page* page = 0;
+  Uint32 *ptr = 0;
+  
+  if (likely(pos.m_page_id != RNIL))
+  {
+    page= (Buffer_page*)m_tup->c_page_pool.getPtr(pos.m_page_id);
+    ptr= page->m_data + pos.m_page_pos;
+  }
 
   const bool same_gci = (gci == pos.m_last_gci) && (!ERROR_INSERTED(13022));
   
Thread
bk commit into 5.1 tree (jonas:1.2043)jonas12 Jan