List:Commits« Previous MessageNext Message »
From:Ritheesh Vedire Date:December 11 2009 10:07am
Subject:Re: bzr commit into mysql-6.0-backup branch (charles.bell:2904)
Bug#49414
View as plain text  
Hi Chuck,

=== STATUS===
 Approved.

==SUGGESTIONS==
1) Improve the commit message. I see very minor mistakes.
     (I don't know if commit messages are to be taken seriously. If yes, 
see the points below )


>
>  2904 Chuck Bell	2009-12-09
>       BUG#49414 : Innodb tbl w/blob and text column with NULL no 
>                   longer NULL after backup/restore
>       
>       The backup default driver was writing blobs even if there
>       was no data then calling a method to set it as not null. 
>   
    [1]     Use of the word 'then' here seems inappropriate to me. You 
meant 'and then'?    
>       This set the fields as not null and wrinting an empty string
>       to the field.
>   
    [2]   *writing *  an empty string.
>       

 --Ritheesh.

 

Thread
bzr commit into mysql-6.0-backup branch (charles.bell:2904) Bug#49414Chuck Bell9 Dec
  • Re: bzr commit into mysql-6.0-backup branch (charles.bell:2904)Bug#49414Ritheesh Vedire11 Dec