List:Commits« Previous MessageNext Message »
From:Sergei Golubchik Date:December 10 2009 7:28am
Subject:Re: bzr commit into mysql-5.1 branch (mats:3180) WL#5151
View as plain text  
Hi, Alfranio!

On Dec 10, Alfranio Correia wrote:
> Hi Mats,
> 
> Excellent and impressive work.
> There are just a few details that need to be fixed before
> it is ready to be pushed.
> 
> STATUS
> ------
>   Not approved.
> 
> REQUIRED CHANGES
> ----------------
> 1 - Is there any particular reason to use the macro below?
> I think the pattern is to write the function name.
> 
> DBUG_ENTER(__FUNCTION__);

perhaps we avoid __FUNCTION__ because it's a non-standard
deprecated gcc keyword ?
:)
 
Regards / Mit vielen Grüßen,
Sergei

-- 
   __  ___     ___ ____  __
  /  |/  /_ __/ __/ __ \/ /   Sergei Golubchik <serg@stripped>
 / /|_/ / // /\ \/ /_/ / /__  Principal Software Engineer/Server Architect
/_/  /_/\_, /___/\___\_\___/  Sun Microsystems GmbH, HRB München 161028
       <___/                  Sonnenallee 1, 85551 Kirchheim-Heimstetten
Geschäftsführer: Thomas Schroeder, Wolfgang Engels, Wolf Frenkel
Vorsitzender des Aufsichtsrates: Martin Häring
Thread
bzr commit into mysql-5.1 branch (mats:3180) WL#5151Mats Kindahl4 Dec
  • Re: bzr commit into mysql-5.1 branch (mats:3180) WL#5151Alfranio Correia10 Dec
    • Re: bzr commit into mysql-5.1 branch (mats:3180) WL#5151Sergei Golubchik10 Dec
    • Re: bzr commit into mysql-5.1 branch (mats:3180) WL#5151Mats Kindahl10 Dec
      • Re: bzr commit into mysql-5.1 branch (mats:3180) WL#5151Alfranio Correia10 Dec
        • Re: bzr commit into mysql-5.1 branch (mats:3180) WL#5151Mats Kindahl10 Dec
  • Re: bzr commit into mysql-5.1 branch (mats:3180) WL#5151Luís Soares10 Dec
    • Re: bzr commit into mysql-5.1 branch (mats:3180) WL#5151Mats Kindahl10 Dec