Luís Soares write:
> Hi Zhenxing,
>
> Nice Work. I shared some of Alfranio's concerns and you
> have answered them already. Also, Please find some more
> comments inline.
>
> STATUS
> ------
> Approved.
>
> REQUIRED CHANGES
> ----------------
> n/a
>
> REQUESTS
> --------
> n/a
>
> SUGGESTIONS
> -----------
> n/a
>
> DETAILS
> -------
>
> See some comments inline.
>
[snip]
> > +UPDATE t1 SET f = CONCAT('up_',CONNECTION_ID()) WHERE i = 20;
> > +UPDATE t1 SET f = CONCAT('up_',CONNECTION_ID()) WHERE i = 19;
> > +UPDATE t1 SET f = CONCAT('up_',CONNECTION_ID()) WHERE i = 18;
> > +UPDATE t1 SET f = CONCAT('up_',CONNECTION_ID()) WHERE i = 17;
> > +UPDATE t1 SET f = CONCAT('up_',CONNECTION_ID()) WHERE i = 16;
> > +UPDATE t1 SET f = CONCAT('up_',CONNECTION_ID()) WHERE i = 15;
> > +UPDATE t1 SET f = CONCAT('up_',CONNECTION_ID()) WHERE i = 14;
> > +UPDATE t1 SET f = CONCAT('up_',CONNECTION_ID()) WHERE i = 13;
> > +UPDATE t1 SET f = CONCAT('up_',CONNECTION_ID()) WHERE i = 12;
> > +UPDATE t1 SET f = CONCAT('up_',CONNECTION_ID()) WHERE i = 11;
> > +UPDATE t1 SET f = CONCAT('up_',CONNECTION_ID()) WHERE i = 10;
> > +UPDATE t1 SET f = CONCAT('up_',CONNECTION_ID()) WHERE i = 9;
> > +UPDATE t1 SET f = CONCAT('up_',CONNECTION_ID()) WHERE i = 8;
> > +UPDATE t1 SET f = CONCAT('up_',CONNECTION_ID()) WHERE i = 7;
> > +UPDATE t1 SET f = CONCAT('up_',CONNECTION_ID()) WHERE i = 6;
> > +UPDATE t1 SET f = CONCAT('up_',CONNECTION_ID()) WHERE i = 5;
> > +UPDATE t1 SET f = CONCAT('up_',CONNECTION_ID()) WHERE i = 4;
> > +UPDATE t1 SET f = CONCAT('up_',CONNECTION_ID()) WHERE i = 3;
> > +UPDATE t1 SET f = CONCAT('up_',CONNECTION_ID()) WHERE i = 2;
> > +UPDATE t1 SET f = CONCAT('up_',CONNECTION_ID()) WHERE i = 1;
>
> Please, make sure that that this is always the case (the i= #) ?
> I see that there is some asynchronous operations with send; which
> maybe can cause the output to change sometimes.
>
This is the sequence of the queries are sent by mysqltest, not the
sequence when they are handled by the server. And I have also run the
test for a whole day without a failure. So this should be OK.
[snip]
> > === modified file 'plugin/semisync/semisync_master.h'
> > --- a/plugin/semisync/semisync_master.h 2009-10-12 13:15:32 +0000
> > +++ b/plugin/semisync/semisync_master.h 2009-11-28 14:48:16 +0000
> > @@ -23,31 +23,26 @@
> > /**
> > This class manages memory for active transaction list.
> >
> > - We record each active transaction with a TranxNode. Because each
> > - session can only have only one open transaction, the total active
> > - transaction nodes can not exceed the maximum sessions. Currently
> > - in MySQL, sessions are the same as connections.
> > + We record each active transaction with a TranxNode, each session
> > + can only have only one open transaction. Because of EVENT, the
>
> only repeats twice in here ^
>
Will fix it.
[snip]
