Re: bzr commit into mysql-5.1-bugteam branch (Dao-Gang.Qu:3192) Bug#42851

[Davi Arnaut]

On 11/26/09 1:45 PM, Andrei Elkin wrote:
> Davi, hello.
>
>     Hi All,
>
>     I think you guys need to stop for a moment, take a deep breath and
>     reflect about what problem needs to be solved.
>
> You have a point. But, Davi, we were "reflecting" today at a phone call chatting
> with
> Serge today.
>

Serge? You mean Sergei?

>     The problem is that a
>     user might trigger messages to be written to the error log, which is a
>     concern since disk space for the error log is limited. The concern is
>     about messages written to the error log.. any kind (be it a warning, a
>     error or a note).
>
> It's a problem, but still separate to one of the bug#42851.

No. The original problem ("spurious" foo messages) of Bug#42851 has 
already been solved, a patch was pushed and everybody was happy. But 
Domas raised a point that the DoS (flooding of the error log) was also a 
concern and needs to be solved. Hence, the bug was kept open and this is 
what needs to be addressed now.

>     This has nothing to do with push_warning nor it is
>     exclusive to replication code -- the case reported on the bug is just
>     one of the various that a user can trigger.
>
> In our consensus view the one is about unfortunate style of sending a particular
> replication
> warning to the user through the error log instead of the session warnings stack.

Yes, but this is solved already.

>  From point of view of the error-log flooding, this view would be looking as a
> workaround.
> Anyway, with or without fixing the flooding issue, our UNSAFE warnings should not go
> into the error-log.

And it has already been solved. The issue at hand is the flooding. This 
is specifically why the bug has been left open.

Regards,

--
Davi Arnaut