| List: | Commits | « Previous MessageNext Message » | |
| From: | Davi Arnaut | Date: | November 24 2009 12:29pm |
| Subject: | Re: bzr commit into mysql-5.1-bugteam branch (Dao-Gang.Qu:3192) Bug#42851 | ||
| View as plain text | |||
On 11/24/09 10:13 AM, Davi Arnaut wrote: > Hi Andrei, > > On 11/24/09 10:07 AM, Andrei Elkin wrote: >> After sleeping, and sleeping on this matter I think we would agree on >> >> 1. Rating for the error log should be done per session >> 2. Rating should target at duplicate messages > > IMHO, we should do either one, not the two. 1. should be enough. Actually, 1 has problems too. For example, in cases where there is a exceptional condition and a storage engine wants to dump a lot of information to the error log in a short period of time. This might inadvertently trigger rate limiting. 2 problems of its own too if we want to detect duplicate messages within a time interval. This is proving to be quite controversial for something that should be kept simple. Perhaps we should stick with what syslog does: eliminate subsequent duplicated messages. We track those by using a checksum on the message format. What do you guys thing? Regards, -- Davi Atnaut
