List:Commits« Previous MessageNext Message »
From:Alexey Kopytov Date:November 23 2009 10:16am
Subject:bzr push into mysql-5.0-bugteam branch (Alexey.Kopytov:2848 to 2849)
View as plain text  
 2849 Alexey Kopytov	2009-11-23 [merge]
      Automerge.

    modified:
      mysql-test/r/group_min_max.result
      mysql-test/t/group_min_max.test
      sql/opt_range.cc
 2848 Georgi Kodinov	2009-11-20 [merge]
      merge

    modified:
      configure.in
=== modified file 'mysql-test/r/group_min_max.result'
--- a/mysql-test/r/group_min_max.result	2009-07-13 15:11:16 +0000
+++ b/mysql-test/r/group_min_max.result	2009-11-17 14:07:14 +0000
@@ -2480,4 +2480,15 @@ SELECT a, MAX(b) FROM t WHERE b > 0 AND 
 a	MAX(b)
 2	1
 DROP TABLE t;
+#
+# Bug #48472: Loose index scan inappropriately chosen for some WHERE
+#             conditions
+# 
+CREATE TABLE t (a INT, b INT, INDEX (a,b));
+INSERT INTO t VALUES (2,0), (2,0), (2,1), (2,1);
+INSERT INTO t SELECT * FROM t;
+SELECT a, MAX(b) FROM t WHERE 0=b+0 GROUP BY a;
+a	MAX(b)
+2	0
+DROP TABLE t;
 End of 5.0 tests

=== modified file 'mysql-test/t/group_min_max.test'
--- a/mysql-test/t/group_min_max.test	2009-07-13 15:11:16 +0000
+++ b/mysql-test/t/group_min_max.test	2009-11-17 14:07:14 +0000
@@ -991,5 +991,17 @@ SELECT a, MAX(b) FROM t WHERE b > 0 AND 
 
 DROP TABLE t;
 
+--echo #
+--echo # Bug #48472: Loose index scan inappropriately chosen for some WHERE
+--echo #             conditions
+--echo # 
+
+CREATE TABLE t (a INT, b INT, INDEX (a,b));
+INSERT INTO t VALUES (2,0), (2,0), (2,1), (2,1);
+INSERT INTO t SELECT * FROM t;                                   
+
+SELECT a, MAX(b) FROM t WHERE 0=b+0 GROUP BY a;
+
+DROP TABLE t;
 
 --echo End of 5.0 tests

=== modified file 'sql/opt_range.cc'
--- a/sql/opt_range.cc	2009-10-23 11:26:48 +0000
+++ b/sql/opt_range.cc	2009-11-17 14:07:14 +0000
@@ -8244,7 +8244,11 @@ check_group_min_max_predicates(COND *con
     }
     else if (cur_arg->const_item())
     {
-      DBUG_RETURN(TRUE);
+      /*
+        For predicates of the form "const OP expr" we also have to check 'expr'
+        to make a decision.
+      */
+      continue;
     }
     else
       DBUG_RETURN(FALSE);


Attachment: [text/bzr-bundle] bzr/alexey.kopytov@sun.com-20091123100535-lc3vxqx624yh5gvv.bundle
Thread
bzr push into mysql-5.0-bugteam branch (Alexey.Kopytov:2848 to 2849)Alexey Kopytov23 Nov