From: Jørgen Løland
Date: November 20 2009 8:54am
Subject: Re: bzr commit into mysql-6.0-codebase-bugfixing branch
 (oystein.grovlen:3718) Bug#46797
List-Archive: http://lists.mysql.com/commits/91037
Message-Id: <4B06593D.9020408@sun.com>
MIME-Version: 1.0
Content-Type: text/plain; format=flowed; charset=ISO-8859-1
Content-Transfer-Encoding: 8BIT

Øystein Grøvlen wrote:
> Jørgen Løland wrote:
>> Oystein,
>>
>> Patch approved, but I recommend two changes:
>>  - Remove engine=myisam so that the test will run on various engines
> 
> I usually do, but left it there since I am not able to check what is 
> sufficient to reproduce the job.  But I guess it is little chance that 
> this is storage engine related, so I will remove this.
> 
>>  - Since you do not know what fixed this bug, you should be careful to
>>    run the test with the specified optimizer switches turned on.
>>    Just remember to reset them afterwards...
> 
> I do not quite understand what you mean here.  Do you think I should run 
> this with different optimizer settings?  I checked with Patrick, and he 
> said it occurred with everything turned on.  Anyway, I think the most 
> important here is to make sure that this works with whatever is the 
> current settings, not to find with which combination of optimizer_switch 
> settings one will be able to reproduce it.

I meant to turn on the same switches as was reported in the bug report. 
But you have a point in that it needs to be tested for whatever is 
currently enabled.

-- 
Jørgen Løland