Re: bzr commit into mysql-5.1-bugteam branch (martin.hansson:3201) Bug#48459

[Martin Hansson]

>>
>> +Warnings:
>> +Warning    1366    Incorrect integer value: '' for column 'e' at row 1
>> +Warning    1366    Incorrect integer value: '' for column 'e' at row 2
> There is no point in inserting wrong data. You can simply insert 0 
> instead of ''.
Done.
>> +# Should not give Valgrind warnings ...
>>    if (key_tree->next_key_part &&
>> -      key_tree->next_key_part->part == key_tree->part+1 &&
>> -      key_tree->next_key_part->type == SEL_ARG::KEY_RANGE)
>> +      key_tree->next_key_part->type == SEL_ARG::KEY_RANGE &&
>> +      key_tree->next_key_part->part == key_tree->part+1)
> There is few more similar places where next_key_part->part is checked 
> prior to
> next_key_part->type. Please grep & swap.
I am a bit worried that gcov will scream at me if I do this without 
writing a test to cover the code. That has happened before, but it was a 
long time ago, with BK on PB1. What do you think?