List:Commits« Previous MessageNext Message »
From:Charles Bell Date:November 16 2009 6:35pm
Subject:Re: bzr commit into mysql-6.0-backup branch (charles.bell:2889)
Bug#47956
View as plain text  
Sanjay,

> Accepting this patch with some requests.
> 
> Requests:
> 1. If possible there should be some tests included.
>    These should show other states besides "complete" in the file.
>    (maybe a failure of privileges)
>    Possibly using the "cat" command as suggested by Rafal.

It is not possible to do this because the file contains dates. Since MTR 
is a comparative testing engine, it means anything resembling a cat 
command would be non-deterministic.

> 2. If possible use a better way than putting in hard coded strings in 
> the code.
>    Internationalized strings would be best.

This would complicate the code considerably. I leave this for a future 
feature request.

...


Chuck

Thread
bzr commit into mysql-6.0-backup branch (charles.bell:2889) Bug#47956Chuck Bell10 Nov
  • Re: bzr commit into mysql-6.0-backup branch (charles.bell:2889)Bug#47956Thava Alagu11 Nov
  • Re: bzr commit into mysql-6.0-backup branch (charles.bell:2889)Bug#47956sanjay Manwani12 Nov
    • Re: bzr commit into mysql-6.0-backup branch (charles.bell:2889)Bug#47956Charles Bell16 Nov