Hi Chuck,
Charles Bell, 16.11.2009 18:34:
> Ingo,
>
> Although you did not request a new patch, I have fixed all of the things
> you cited here and generated a new patch for you to review.
Sorry, but I can't afford the time to review patch after patch, each
perhaps addressing a few issues. I will no longer re-review patches
until all my issues are addressed (implemented or explained). For this
patch it means to document architecture approval.
...
> Console here is the output to the user like:
>
> 091116 11:23:08 [Note] Backup: Backup completed
> 091116 11:23:08 [Note] Restore: Starting restore process
> 091116 11:23:08 [Note] Restore: Restoring 1 database(s) `bup_events`
To me this looks like lines from the error log. A normal user won't have
access to it. The user normally sees only messages as can be found in
the test result file.
...
>>> + /*
>>> + We update the mysql table directly to avoid changing character
>>> + collation or character set, modified by, etc.
>>
>>
>> But suddenly we require UPDATE_ACL on mysql.event.
>
> Yes. I did not include changes here as BUG#44787 will simply undo them
> anyway. So we're safe provided BUG#44787 gets pushed. :)
Why would the privilege patch undo changes from from the event disabling
patch?
I think, the new requirement for UPDATE_ACL on mysql.event is a severe
one. By now, we needed SELECT on some system tables. And there was hope
that this could be avoided by a new information schema table. But now we
will need write access to a system table forever. :(
...
Regards
Ingo
--
Ingo Strüwing, Database Group
Sun Microsystems GmbH, Sonnenallee 1, D-85551 Kirchheim-Heimstetten
Geschäftsführer: Thomas Schröder, Wolfgang Engels, Wolf Frenkel
Vorsitzender des Aufsichtsrates: Martin Häring HRB München 161028
